Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorise binary log_sum_exp #2930

Merged
merged 2 commits into from
Aug 12, 2023
Merged

Conversation

andrjohns
Copy link
Collaborator

Summary

This is a small PR vectorising the binary signature of log_sum_exp, which was missed when vectorising all binary functions

Tests

Additional prim and mix tests added for the broadcasted versions

Side Effects

N/A

Release notes

Vectorised binary signature for log_sum_exp

Checklist

  • Math issue vectorize binary log_sum_exp #2924

  • Copyright holder: Andrew Johnson

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

Copy link
Collaborator

@SteveBronder SteveBronder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andrjohns andrjohns merged commit d4eab27 into develop Aug 12, 2023
7 checks passed
@WardBrian WardBrian deleted the issue-2924-vectorised-log_sum_exp branch August 22, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants