Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup of numerical stability, constants, compound functions in OpenCL kernels #2934

Merged
merged 9 commits into from
Sep 18, 2023

Conversation

andrjohns
Copy link
Collaborator

Summary

Small PR tidying the OpenCL kernels to use built-in constants and more numerically stable expressions

Tests

N/A - Existing tests should pass

Side Effects

N/A

Release notes

Minor cleanup of numerical stability, constants, compound functions in OpenCL kernels

Checklist

  • Math issue #(issue number)

  • Copyright holder: Andrew Johnson

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

rok-cesnovar
rok-cesnovar previously approved these changes Aug 28, 2023
Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrjohns
Copy link
Collaborator Author

@rok-cesnovar Would you mind re-approving when you get a minute?

Copy link
Collaborator

@SteveBronder SteveBronder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Though we should wait to merge till after the release

@andrjohns andrjohns merged commit c001c71 into develop Sep 18, 2023
7 checks passed
@andrjohns andrjohns deleted the opencl-kernel-cleanups branch September 18, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants