Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't duplicate -rpath for TBB #2952

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Don't duplicate -rpath for TBB #2952

merged 3 commits into from
Oct 4, 2023

Conversation

WardBrian
Copy link
Member

Summary

Reported on the forums, some versions of ld are now issuing warnings for repeated copies of -rpath.
I think the fact that we were passing it twice already was an error/misinterpretation of LDFLAGS and LDLIBS.

Tests

Side Effects

Release notes

Fixed the RPATH to the TBB library being passed twice on the command line

Checklist

  • Math issue #(issue number)

  • Copyright holder: (fill in copyright holder information)

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@WardBrian
Copy link
Member Author

@andrjohns is the failure here related to #2947 ?

@andrjohns
Copy link
Collaborator

@andrjohns is the failure here related to #2947 ?

Looks like it was just a temporary download error, restart the actions run and all seems to be fine

@WardBrian WardBrian requested a review from syclik October 3, 2023 16:32
Copy link
Collaborator

@andrjohns andrjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WardBrian WardBrian merged commit 11b3aff into develop Oct 4, 2023
8 checks passed
@WardBrian WardBrian deleted the fix/double-rpath branch November 29, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants