Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rstan3 directory #906

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jeffreypullin
Copy link
Contributor

Summary:

Remove the (obsolete?) rstan3 directory following up on #898

Intended Effect:

Simplification of the structure of the repository

How to Verify:

These changes should be non-functional.

Reviewer Suggestions:

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Jeffrey Pullin

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@hsbadr
Copy link
Member

hsbadr commented Feb 4, 2021

@jeffreypullin Agreed. I've picked this in #887 at 23a7869.

@jeffreypullin
Copy link
Contributor Author

@hsbadr I'm happy for this to be picked into #887 but given how big #887 already is it might just be easier for @bgoodri to review and merge separately.

@hsbadr
Copy link
Member

hsbadr commented Feb 4, 2021

@hsbadr I'm happy for this to be picked into #887 but given how big #887 already is it might just be easier for @bgoodri to review and merge separately.

Yes. After this gets merged, it'll have to be applied to #887 anyway to resolve merging conflicts. Hope both will get merged & we start from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants