Add additional dialect, fix and improve comments on convert_british_to_american #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested another half-dozen or so of our books that had b2a run on them, including two Dickens, which have a lot of dialect. The good news is that things are much improved. I also found three more words to add to the reverse quote dialect regex, and removed is—the latter occurs far more often as the real word in an opening quote than as dialect. (I've only found the ‘is as dialect in one book, vs ‘is as the real word in all but one of the others.)
I also fixed a comment in the overview, and added one on the double quote regexes.