Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and use Node 20 #9

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Update dependencies and use Node 20 #9

merged 1 commit into from
Sep 17, 2024

Conversation

nineinchnick
Copy link
Member

Update dependencies and use Node 20 to avoid deprecation warnings in GitHub Action run summary.
Octokit dependencies are locked to latest versions before converting to ES modules.

These updates mirror updates done for action-surefire-report in trinodb/github-actions#32

@nineinchnick
Copy link
Member Author

Node 20 changed its http client so nock has issues mocking it. I tried using a beta version, which worked in action-surefire-report, but it somehow doesn't work here.

wendigo
wendigo reviewed Sep 17, 2024
View reviewed changes
eslint.config.cjs Outdated Show resolved Hide resolved
@nineinchnick nineinchnick merged commit f245422 into master Sep 17, 2024
1 check passed
@nineinchnick nineinchnick deleted the update-dependencies branch September 17, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendigo wendigo wendigo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nineinchnick @wendigo