-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only set the comment when persist_docs.relation is set #344
Only set the comment when persist_docs.relation is set #344
Conversation
609f644
to
2432b48
Compare
Gentle ping @damian3031 |
@Fokko I added tests for this change |
Gentle ping @Fokko 🙂 Please adjust to (or comment on) the requested changes, and PR is good to merge |
@damian3031 Sorry for not replying earlier, thanks for adding tests, and the changes look good 👍🏻 |
@Fokko thanks! Could you squash these 2 new commits into the first one? (this one |
7e75813
to
46b8d0a
Compare
@Fokko thanks for your contribution! |
@Fokko Thank you for fixing this. When is the next release actually? |
@alaturqua It has just been released in 1.6.2! |
Thanks @damian3031 for shepherding this, and sorry @alaturqua for breaking this |
Overview
I accidentally changed default behavior in #317
Resolves #343
Checked that it only sets the comment when:
And with the following configuration it won't set the comment:
Checklist
README.md
updated and added information about my changechangie new
to create a changelog entry