fix warnings

starcoinorg · Aug 1, 2024 · a8a7831 · a8a7831
1 parent 8ad3c81
commit a8a7831
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/vm/vm-runtime/src/verifier/transaction_arg_validation.rs b/vm/vm-runtime/src/verifier/transaction_arg_validation.rs
@@ -108,7 +108,7 @@ pub(crate) fn validate_combine_singer_and_args<S: MoveResolverExt>(
     // Need to keep this here to ensure we return the historic correct error code for replay
     for ty in func.parameters[signer_param_cnt..].iter() {
         let valid = is_valid_txn_arg(
-            &session,
+            session,
             &ty.subst(&func.type_arguments).unwrap(),
             allowed_structs,
         );

diff --git a/vm/vm-runtime/src/vm_adapter/adapter.rs b/vm/vm-runtime/src/vm_adapter/adapter.rs
@@ -231,7 +231,7 @@ impl<'r, 'l, R: MoveResolver> SessionAdapter<'r, 'l, R> {
                 let old_module_ref = self.inner.load_module(&module_id)?;
                 let old_module = old_module_ref.module();
                 let old_m = normalized::Module::new(old_module);
-                let new_m = normalized::Module::new(&module);
+                let new_m = normalized::Module::new(module);
                 if Compatibility::new(true, true, false)
                     .check(&old_m, &new_m)
                     .is_err()
@@ -306,7 +306,7 @@ impl<'r, 'l, R: MoveResolver> SessionAdapter<'r, 'l, R> {
 
     //ensure the script function not return value
     pub(crate) fn check_script_return(return_: Vec<Type>) -> VMResult<()> {
-        return if !return_.is_empty() {
+        if !return_.is_empty() {
             Err(PartialVMError::new(StatusCode::RET_TYPE_MISMATCH_ERROR)
                 .with_message(format!(
                     "Expected script function should not return value, but got {:?}",
@@ -315,7 +315,7 @@ impl<'r, 'l, R: MoveResolver> SessionAdapter<'r, 'l, R> {
                 .finish(Location::Undefined))
         } else {
             Ok(())
-        };
+        }
     }
 
     fn check_script_signer_and_build_args(