Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate move repo #4177

Closed
wants to merge 12 commits into from
Closed

Migrate move repo #4177

wants to merge 12 commits into from

Conversation

simonjiao
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

coderabbitai bot commented Aug 7, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

1. commit hash in starcoinorg/move: 905484b15b2a2218013fdb2c034f1d7898d29a25
1. remove unused crate: commons/proptest-helpers
2. fix serde version for dataformat-generator
Copy link

github-actions bot commented Aug 7, 2024

Benchmark for d100bea

Click to view benchmark
Test Base PR %
accumulator_append 794.9±107.74µs 758.7±99.32µs -4.55%
block_apply/block_apply_10 377.5±14.61ms 369.8±10.57ms -2.04%
block_apply/block_apply_1000 39.7±0.82s 38.3±1.05s -3.53%
get_with_proof/db_store 46.7±5.76µs 46.3±3.78µs -0.86%
get_with_proof/mem_store 38.0±5.81µs 38.3±5.21µs +0.79%
put_and_commit/db_store/1 116.0±5.26µs 111.3±5.18µs -4.05%
put_and_commit/db_store/10 1060.2±111.03µs 992.4±39.28µs -6.40%
put_and_commit/db_store/100 9.5±0.57ms 9.6±0.29ms +1.05%
put_and_commit/db_store/5 524.6±26.33µs 537.4±70.66µs +2.44%
put_and_commit/db_store/50 4.8±0.20ms 4.9±0.20ms +2.08%
put_and_commit/mem_store/1 72.1±6.99µs 71.3±6.57µs -1.11%
put_and_commit/mem_store/10 677.6±72.63µs 676.4±71.24µs -0.18%
put_and_commit/mem_store/100 6.5±0.57ms 6.6±0.57ms +1.54%
put_and_commit/mem_store/5 339.1±29.55µs 339.1±30.25µs 0.00%
put_and_commit/mem_store/50 3.3±0.27ms 3.5±0.79ms +6.06%
query_block/query_block_in(10)_times(100) 5.8±1.68ms 4.4±0.21ms -24.14%
query_block/query_block_in(10)_times(1000) 45.4±1.39ms 44.6±1.06ms -1.76%
query_block/query_block_in(10)_times(10000) 449.4±12.09ms 444.4±8.78ms -1.11%
query_block/query_block_in(1000)_times(100) 1357.9±282.85µs 1155.6±28.17µs -14.90%
query_block/query_block_in(1000)_times(1000) 12.9±3.55ms 11.4±0.15ms -11.63%
query_block/query_block_in(1000)_times(10000) 108.4±1.41ms 116.0±1.51ms +7.01%
storage_transaction 1113.5±469.65µs 1164.7±440.96µs +4.60%
vm/transaction_execution/1 435.3±28.61ms 432.0±11.16ms -0.76%
vm/transaction_execution/10 138.7±8.84ms 133.7±7.62ms -3.60%
vm/transaction_execution/20 127.8±10.95ms 127.0±7.38ms -0.63%
vm/transaction_execution/5 173.9±16.18ms 163.4±5.16ms -6.04%
vm/transaction_execution/50 150.9±10.15ms 145.4±7.95ms -3.64%

Copy link

github-actions bot commented Aug 8, 2024

Benchmark for 464dbb7

Click to view benchmark
Test Base PR %
accumulator_append 724.3±46.80µs 724.1±41.65µs -0.03%
block_apply/block_apply_10 354.0±9.41ms 356.9±5.41ms +0.82%
block_apply/block_apply_1000 38.1±0.86s 38.4±0.75s +0.79%
get_with_proof/db_store 45.7±1.16µs 45.7±1.94µs 0.00%
get_with_proof/mem_store 37.4±1.22µs 36.7±1.56µs -1.87%
put_and_commit/db_store/1 114.5±4.97µs 114.4±6.06µs -0.09%
put_and_commit/db_store/10 991.1±39.74µs 1032.4±44.51µs +4.17%
put_and_commit/db_store/100 9.1±0.82ms 9.6±0.57ms +5.49%
put_and_commit/db_store/5 518.3±23.97µs 533.5±29.80µs +2.93%
put_and_commit/db_store/50 4.7±0.28ms 4.8±0.19ms +2.13%
put_and_commit/mem_store/1 73.1±9.81µs 71.0±6.28µs -2.87%
put_and_commit/mem_store/10 666.2±80.78µs 664.4±50.80µs -0.27%
put_and_commit/mem_store/100 6.5±0.73ms 6.6±0.65ms +1.54%
put_and_commit/mem_store/5 341.6±35.53µs 337.7±28.25µs -1.14%
put_and_commit/mem_store/50 3.2±0.15ms 3.3±0.28ms +3.13%
query_block/query_block_in(10)_times(100) 4.5±0.27ms 4.6±0.18ms +2.22%
query_block/query_block_in(10)_times(1000) 45.8±1.71ms 46.0±3.50ms +0.44%
query_block/query_block_in(10)_times(10000) 448.1±9.13ms 482.2±85.18ms +7.61%
query_block/query_block_in(1000)_times(100) 1106.9±21.32µs 1155.2±14.96µs +4.36%
query_block/query_block_in(1000)_times(1000) 11.1±0.45ms 11.8±0.53ms +6.31%
query_block/query_block_in(1000)_times(10000) 110.9±3.07ms 116.7±5.10ms +5.23%
storage_transaction 1049.2±380.43µs 1049.2±393.08µs 0.00%
vm/transaction_execution/1 412.2±11.69ms 415.6±19.11ms +0.82%
vm/transaction_execution/10 126.4±3.31ms 128.6±6.10ms +1.74%
vm/transaction_execution/20 117.1±1.76ms 116.6±1.83ms -0.43%
vm/transaction_execution/5 165.2±11.65ms 154.4±2.57ms -6.54%
vm/transaction_execution/50 137.0±5.28ms 135.0±3.37ms -1.46%

@simonjiao simonjiao closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants