Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starcoin-config): rm unused crate #4224

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Oct 6, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Summary by CodeRabbit

  • Chores
    • Removed the dependency on stdlib from the configuration package.

@nkysg nkysg requested a review from welbon October 6, 2024 01:13
Copy link

coderabbitai bot commented Oct 6, 2024

Walkthrough

The changes involve the modification of the Cargo.toml file for the starcoin-config package. The primary alteration is the removal of the stdlib dependency from the [dependencies] section. All other dependencies, workspace settings, and feature specifications remain unchanged, and the [package] section is unaffected.

Changes

File Change Summary
config/Cargo.toml Removed stdlib dependency from [dependencies]

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Cargo
    User->>Cargo: Request build
    Cargo->>Cargo: Check dependencies
    Cargo-->>User: Build successful
Loading

Poem

In the garden where code does play,
A dependency hopped away,
With stdlib gone, the path is clear,
The project blooms, full of cheer!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a6f499b and d8c1bda.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • config/Cargo.toml (0 hunks)
💤 Files with no reviewable changes (1)
  • config/Cargo.toml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Oct 6, 2024

Benchmark for 02bc2be

Click to view benchmark
Test Base PR %
accumulator_append 837.7±179.11µs 793.9±94.86µs -5.23%
block_apply/block_apply_10 379.1±13.29ms 378.2±17.19ms -0.24%
block_apply/block_apply_1000 41.6±1.30s 43.7±2.86s +5.05%
get_with_proof/db_store 51.7±12.54µs 46.6±8.73µs -9.86%
get_with_proof/mem_store 35.9±1.43µs 55.6±8.20µs +54.87%
put_and_commit/db_store/1 132.5±18.28µs 129.1±15.83µs -2.57%
put_and_commit/db_store/10 1122.3±124.06µs 1191.6±187.62µs +6.17%
put_and_commit/db_store/100 10.4±0.99ms 9.8±0.78ms -5.77%
put_and_commit/db_store/5 549.5±42.81µs 570.9±64.56µs +3.89%
put_and_commit/db_store/50 5.3±0.63ms 5.4±0.70ms +1.89%
put_and_commit/mem_store/1 71.4±8.75µs 73.4±11.99µs +2.80%
put_and_commit/mem_store/10 669.3±73.17µs 665.5±71.17µs -0.57%
put_and_commit/mem_store/100 7.1±1.15ms 6.4±0.37ms -9.86%
put_and_commit/mem_store/5 373.9±89.64µs 368.9±66.60µs -1.34%
put_and_commit/mem_store/50 3.3±0.33ms 4.0±0.89ms +21.21%
query_block/query_block_in(10)_times(100) 8.9±0.61ms 9.1±1.11ms +2.25%
query_block/query_block_in(10)_times(1000) 87.6±4.20ms 93.8±11.68ms +7.08%
query_block/query_block_in(10)_times(10000) 894.6±35.88ms 880.7±42.79ms -1.55%
query_block/query_block_in(1000)_times(100) 2.1±0.33ms 1779.4±101.19µs -15.27%
query_block/query_block_in(1000)_times(1000) 18.3±1.75ms 17.6±1.56ms -3.83%
query_block/query_block_in(1000)_times(10000) 177.1±13.51ms 179.8±5.92ms +1.52%
storage_transaction 1135.4±433.93µs 1198.3±487.64µs +5.54%
vm/transaction_execution/1 514.3±63.36ms 412.8±13.53ms -19.74%
vm/transaction_execution/10 137.3±9.99ms 133.3±7.16ms -2.91%
vm/transaction_execution/20 129.8±10.46ms 122.7±6.18ms -5.47%
vm/transaction_execution/5 176.7±12.15ms 158.0±9.67ms -10.58%
vm/transaction_execution/50 150.5±13.33ms 145.4±12.29ms -3.39%

@nkysg nkysg merged commit a942d7d into dag-master Oct 8, 2024
4 of 5 checks passed
@nkysg nkysg deleted the remove_unused_deps branch October 8, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants