Fix overflow handling #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ISO Pascal compiler fails to parse numeric literals, raising an "Integer overflow" error by executing a BRK instruction. This error appears to occur due to an incorrect overflow condition that was fixed in the somewhat related B-Em source code. Thus, it makes sense to introduce B-Em's NMOS implementation of ADC/SBC into Elkulator to keep the two programs synchronised and to benefit from the fixes made to B-Em.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix introduces the ADC/SBC implementation from B-Em to fix overflow bugs that manifest themselves in ISO Pascal when the compiler is parsing numeric literals.