Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(RSS-ECOMM-2_53): apply changes and fixes to prod for cross-check #205

Merged
merged 5 commits into from
May 8, 2024

Conversation

stardustmeg
Copy link
Owner

@stardustmeg stardustmeg commented May 8, 2024

PR Title ✨

πŸ“ conforms with the following format:

  • prefix (following the convention: feat, fix, hotfix, chore, refactor, revert, docs, style, test)
  • sprint and issue number (e.g. RSS-ECOMM-3_01, where 3 - is the sprint number and 01 - is the issue number)
  • short description

πŸ‘€ Example: feat(RSS-ECOMM-2_01): description

PR Description πŸ§™β€β™‚οΈ

  • Separate validators into separate functions.
  • Separate address logic into Address component.
  • Change getIsValid method.
  • Replace type for authCustomer method.
  • Separate disabling into ButtonView.
  • Fix pattern for validate.
  • Add types for Address component.
  • Create messageTemplate.
  • Create every inputField separately.
  • Fix header styles.

Auto-Review πŸ€–

  • The reviewers have been requested πŸ“
    Request Review on PR Open
  • The labels have been added 🎨
    Pull Request Labeler
  • My code doesn't generate any errors or warnings ⛓️
    Continuous Integration
  • My code builds successfully βš™οΈ
    Netlify Status

Self-Check 🌟

  • I wrote the correct title for the PR πŸ—οΈ
  • I wrote a comprehensive description for the PR πŸ“œ
  • I have performed a self-review of my own code βœ…
  • I have commented my code where needed πŸ“
  • I am happy with my PR and ready to merge ❀️‍πŸ”₯

stardustmeg and others added 5 commits May 7, 2024 04:55
…#199)

* docs: update the PR template

* chore: add a job to generate PR titles

* chore: remove unnecessary paths from configs

* chore: remove unused package

* chore: remove a job from CI
* refactor: remove redundant tag constant

* refactor: replace redundant event names
* feat: add size product count request

* feat: add filter, edit sort, edit get product request

* feat: add search options
* refactor: separate validators into separate functions

* refactor: separate address logic into Address component

* refactor: change getIsValid method

* fix: replace type for authCustomer method

* refactor: separate disabling into ButtonView

* fix: pattern for validate

* feat: types for Address component

* feat: create messageTemplate

* refactor: create every inputField separately

* refactor: create every inputField separately

* fix: header styles
@github-actions github-actions bot requested review from Kleostro and YulikK May 8, 2024 07:17
@github-actions github-actions bot added documentation Improvements or additions to documentation test style labels May 8, 2024
Copy link

netlify bot commented May 8, 2024

βœ… Deploy Preview for mad-wizards-greenshop-develop ready!

Name Link
πŸ”¨ Latest commit 37be0e8
πŸ” Latest deploy log https://app.netlify.com/sites/mad-wizards-greenshop-develop/deploys/663b26e7b954310008848c56
😎 Deploy Preview https://deploy-preview-205--mad-wizards-greenshop-develop.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 8, 2024

βœ… Deploy Preview for mad-wizards-greenshop ready!

Name Link
πŸ”¨ Latest commit 37be0e8
πŸ” Latest deploy log https://app.netlify.com/sites/mad-wizards-greenshop/deploys/663b26e7d6be0c00082a6340
😎 Deploy Preview https://deploy-preview-205--mad-wizards-greenshop.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stardustmeg stardustmeg merged commit 55e2cff into develop May 8, 2024
12 checks passed
@stardustmeg
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross check ⭐ documentation Improvements or additions to documentation style test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants