-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(RSS-ECOMM-4_96): cart blog footer #328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mad-wizards-greenshop-develop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stardustmeg
changed the title
Fix(RSS-ECOMM-4_96)/cart blog footer
fix(RSS-ECOMM-4_96): cart blog footer
Jun 2, 2024
stardustmeg
approved these changes
Jun 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job! Thank you a ton ❤️
Nice work replacing those magic strings too 👍🏻
stardustmeg
added a commit
that referenced
this pull request
Jun 3, 2024
…t_4] (#334) * chore(RSS-ECOMM-4_00): update sprint number (#309) chore: update sprint number * refactor(RSS-ECOMM-4_30): update styles (#311) refactor(RSS-ECOMM-3_58): separate styles in mixins (#310) * docs(RSS-ECOMM-2_37): Update pipeline scripts and CD for a new sprint (#199) * docs: update the PR template * chore: add a job to generate PR titles * chore: remove unnecessary paths from configs * chore: remove unused package * chore: remove a job from CI * refactor(RSS-ECOMM-3_27): remove redundancies (#202) * refactor: remove redundant tag constant * refactor: replace redundant event names * feat(RSS-ECOMM-3_03): add filters (#201) * feat: add size product count request * feat: add filter, edit sort, edit get product request * feat: add search options * refactor(RSS-ECOMM-2_53): registration form (#204) * refactor: separate validators into separate functions * refactor: separate address logic into Address component * refactor: change getIsValid method * fix: replace type for authCustomer method * refactor: separate disabling into ButtonView * fix: pattern for validate * feat: types for Address component * feat: create messageTemplate * refactor: create every inputField separately * refactor: create every inputField separately * fix: header styles * fix(RSS-ECOMM-2_54): visualisation forms (#206) * fix: layout registration form * fix: layout login form * fix: layout address * fix: layout countryChoice * fix: layout login and registration pages * refactor: remove the mandatory field symbol from field signatures in forms * feat: add formatted text function * fix: remove formatting from fields that should not be formatted * feat: formatting of address fields * refactor(RSS-ECOMM-2_55): router component (#207) * refactor: rewrite Router component * fix: navigation links * fix: choosing country * refactor: country lang choice based on input * refactor: visual layout of pages * fix: update store * refactor: remove redundant code * fix: styles * feat: add init method for App component * Apply suggestions from code review --------- * feat(RSS-ECOMM-2_99): edit api client (#209) feat: add save token, add auth and anonym client * feat(RSS-ECOMM-3_29): pages lazy loading (#210) * feat: implement lazy loading for pages * fix: add a catch block * feat(RSS-ECOMM-3_30): implement language switch (#212) * feat: implement switching language on registration checkboxes * feat: switch titles language * feat: implement label text switching * test: observe current language * feat: add language choice to user messages * fix: showPasswordElement position * refactor: update text content in Russian * feat: add a logo for language switch * fix(RSS-ECOMM-3_31): rerouting to main (#213) fix: rerouting to main * feat(RSS-ECOMM-3_25): create pages components (#214) * feat: add base page components * docs: update PR template * fix: link styles * fix: button naming * Apply suggestions from code review --------- * feat(RSS-ECOMM-3_19): implement routing for all pages (#215) feat: implement routing for all pages * feat(RSS-ECOMM-3_21): implement navigation (#217) * feat: implement navigation to catalog and cart pages * fix: footer styles * fix: header styles * feat: implement navigation to other pages * feat: check auth user to profile page * feat: check auth user with init app * feat: visually profile button * feat(RSS-ECOMM-3_34): add catalog component (#218) feat: add catalog component * feat(RSS-ECOMM-3_33): implement burger menu (#221) feat: implement burger menu * feat(RSS-ECOMM-3_01): implement product list (#223) * refactor: api types * feat: implement product list * feat(RSS-ECOMM-3_36): implement theme app (#225) * feat: implement app theme change * feat: save current app theme in store * fix: update store actions * feat(RSS-ECOMM-3_02): display price and discount (#226) * fix: api types for product * feat: display price and discount on product card * fix: rename SizeType * feat(RSS-ECOMM-3_99): add blog page (#228) * feat: add blog page * feat: add blog page, posts, widget * refactor: delete comment and magic numbers * fix: mock data * feat(RSS-ECOMM-3_03): implement filtering product list (#227) * feat: expand loder options * fix: styles product card * feat: implement saving Set into LS Co-authored-by: Meg G. <[email protected]> * feat: get and draw product items * feat: create ProductFilters component * feat: implement price filter * feat: implement size filter * feat: filters reset button * fix: burger styles * fix: lost title * feat(RSS-ECOMM-3_98): add all data in one request (#229) * feat: add all data in one request * feat: add refresh token, fix auth, refactor client * fix(RSS-ECOMM-3_40): handle popstate event (#231) fix: handle popstate event * feat(RSS-ECOMM-3_37): implement switching user locale (#233) * feat: add a user notification on switching language * feat: implement switching locale * feat(RSS-ECOMM-3_97): add filter Object, make filer with OR concatenation (#230) * feat: add filter Object, make filer with OR concatenation * refactor: delete comment * feat: add categoryCount and SizeCount to Products response * feat(RSS-ECOMM-3_03): implement meta filters (#235) * fix: router * feat: implement meta filters * Apply suggestions from code review --------- * test(RSS-ECOMM-3_24): cover main codebase (#236) test(RSS-ECOMM-3_24): cover main codebase * refactor(RSS-ECOMM-3_41): logic input components (#237) * feat: create method to add data attributes for input * refactor: remove unused data for creating input fields * refactor: delete unused options for address component * feat(RSS-ECOMM-3_14): display user info (#234) * feat: add user info menu * refactor: replace recurring code with a util function * feat: add common utils * feat: display user info * refactor: remove the language switch * chore: complete merge * refactor: remove sending request until user is logged in on refresh * refactor: move language choice from buttons constants * feat: add modal * fix: remove unused var * fix: modal styles * feat: create separate entities for user info and user addresses * refactor: remove redundant code * refactor: add comments * feat(RSS-ECOMM-3_04): implement product sorts (#238) * chore: integrate plop to create component folder * chore: add templates folder * docs: update readme * chore: update configs * chore: update configs * feat: implement products sorting * Apply suggestions from code review * fix: after merge --------- * feat(RSS-ECOMM-3_96): add cart and shop list (#239) * feat: add cart, refactor root, delete product from store * feat: add and delete cart item * feat: add anonymId to store, merge anonym cart after login user * feat: create create for new customer, getCart * feat: add shoppingList * feat: create shopping list after registration * feat: getCategories function * feat(RSS-ECOMM-3_95): add price range (#240) feat: add price range * feat(RSS-ECOMM-3_42): transfer styles to clamp (#242) * refactor: transfer to clamp * refactor: remove background with unused pictures * refactor: remove commented out code * chore(RSS-ECOMM-3_43): modernise the creation of a component via plopfile (#243) chore: modernise the creation of a component via plopfile * chore(RSS-ECOMM-3_44): update display select list in terminal (#244) chore: update display select list in terminal * fix(RSS-ECOMM-3_45): styles (#245) * fix: sorting wrapper style * fix: error and burger z-indices * chore(RSS-ECOMM-3_45): update readme (#246) * docs: update readme * chore: update vite configs to minify build code * fix: typo * feat(RSS-ECOMM-3_05): implement product search (#247) * feat: create product search component * feat: implement product search * feat(RSS-ECOMM-3_94): update user addresses; save token to store (#248) * feat: move save token from cook to store * feat: add shipping billing address to user * feat(RSS-ECOMM-3_46): implement custom scroll (#249) feat: implement custom scroll * fix(RSS-ECOMM-3_47): display products with selected filters (#250) fix: display products with selected filters * feat(RSS-ECOMM-3_94): add id filter for products (#251) feat: add id filter for products * feat(RSS-ECOMM-3_48): implement buttons to product card (#252) * feat: implement buttons to product card * feat: getters * feat(RSS-ECOMM-3_48): translate filters, sorting and search (#254) feat: translate filters, sorting and search * feat(RSS-ECOMM-3_49): add product to cart and wishlist (#255) feat: add product to cart and wishlist * fix(RSS-ECOMM-3_50): incoming product card parameters (#256) * fix: incoming product card parameters * fix: catalog styles * feat(RSS-ECOMM-3_93): add getCurrentUser (#257) feat: add getCurrentUser * fix(RSS-ECOMM-3_51): router component (#258) * fix: routing to detailed product page * fix: redirect to default page * feat(RSS-ECOMM-3_92): add parent to category (#260) * refactor(RSS-ECOMM-3_52): router component (#261) * refactor: get rid of asynchronous methods in the router * refactor: add / at the end of each route * feat: add search queries to url * fix: router test * fix: update netlify * fix: update netlify * fix: update netlify * fix: update netlify * fix: router * fix: router * feat(RSS-ECOMM-3_91): update auth client after password change (#263) feat: update auth client after password change * feat(RSS-ECOMM-3_91): add slug for category and product (#262) feat: add slug for category and product * feat(RSS-ECOMM-3_15): update user info (#253) * refactor: separate PersonalInfoComponent * refactor: separate credentials into a single component * refactor: remove user from store * feat: add a request before showing personal info * feat: implement changing password * fix: switch language for anonymous user * refactor: create one instance of modal content * fix: navigation styles * fix: redirect to main on logo * feat(RSS-ECOMM-3_08): implement breadcrumb navigation (#289) * feat: implement event mediator component * feat: implement search params in url * refactor: remove user from state * feat: implement breadcrumbs * Update src/shared/constants/sorting.ts * fix: prettier --------- * feat(RSS-ECOMM-3_09): display product details on product page (#294) feat: display product details on product page * feat(RSS_ECOMM-3_90): add key request (#295) feat: add key request * feat(RSS-ECOMM-3_89): add adapt Product (#296) feat: add adapt Product * feat(RSS-ECOMM-3_10): implement slider on product page (#297) feat: implement slider on product page * fix(RSS-ECOMM-3_53): routing on product page (#298) * fix: routing on product page * fix: search params * feat(RSS-ECOMM-3_13): implement product modal slider (#299) feat: implement product modal slider * feat(RSS-ECOMM-3_90) cart (#300) * feat: add cart page * feat: badge for cart * feat: add actions for cart products * feat: merge cart after registration * feat(RSS-ECOMM-3_16): implement personal info edit (#301) * feat: close modal on click on background * feat: implement personal info edit * feat: implement changing component styles * refactor(RSS-ECOMM-3_54): router component (#303) * refactor: make Router singleton * refactor: remove redundant router field * feat: separate product price in component * refactor: styles * Apply suggestions from code review * fix: prettier --------- * feat(RSS-ECOMM-4_08): implement cart button to product page (#304) * feat: add modal window closing on click outside the window * feat: add a modal window with product details * feat: add loader in product modal slider * feat: implement cart button to product page * Apply suggestions from code review --------- * fix(RSS-ECOMM-3_55): deploy (#305) fix: deploy * feat(RSS-ECOMM-3_56): add progress bar to server message (#307) feat: add progress bar to server message * refactor: separate style buttons in mixin * fix: delete navigation from footer --------- Co-authored-by: Max <[email protected]> Co-authored-by: Yuliya Kursevich <[email protected]> * feat(RSS-ECOMM-4_99): add navigate and languages to footer (#312) * feat: add navigate and languages * feat: translate for social and pay * feat: styles * feat(RSS-ECOMM-4_31): adaptive (#314) * feat: add scroll top on every page * feat: adaptive noUiSlider * feat: add adaptive up to 380px * feat(RSS-ECOMM-4_98): add level to product (#313) feat: add level to product * feat(RSS-ECOMM-4_97): add address actions (#315) feat: add address actions * feat(RSS-ECOMM-4_96): add total count for products (#316) feat: add total count for products * feat(RSS-ECOMM-4_03): implement effecting loading products (#318) * feat: separate control search params in router * feat: add pagination component * refactor: remove redundant fields in store * feat(RSS-ECOMM-4_32): display difficultyPlants (#319) * feat: display difficultyPlants * fix: position difficulty plants * feat(RSS-ECOMM-3_18): implement addresses management (#317) * feat: implement adding address * feat: implement adding billing and shipping address * feat: add default address * feat: add styles to add address form * feat: add mixins * feat: implement deleting address * refactor: add error message to a message notification * refactor: remove determining address type to a separate function * feat: implement redrawing after changes * fix: determine address type * fix(RSS-ECOMM-4_33): reloading product page (#320) fix: reloading product page * feat(RSS-ECOMM-4_10)/cart (#321) * feat: modify quantity * feat: delete button for mobile * feat: add clear cart * feat: language and message * fix: src img * feat(RSS-ECOMM-4_97): filter range (#323) * feat: filter Type * feat: catalog filter * feat: filter price range * feat(RSS-ECOMM-4_33): implement editing address (#322) * feat: implement Confirm component * fix: styles for responsive * feat: add confirmation message * fix: dark theme variable * feat: implement changing address fields * feat: add styles to edit address window * feat: add remove content method to modal * fix(RSS-ECOMM-4_34): catalog (#324) * fix: country validation * fix: last link in breadcrumbs * fix: range price slider * feat(RSS-ECOMM-4_35): update address editing (#325) * feat: update errorMessage to include a custom message * feat: update edit to remove default only * fix: typo in title * feat: add loader for address request * refactor: replace bin picture * fix(RSS-ECOMM-4_36): user addresses (#326) * fix: validation postal code * fix: display user addresses * feat(RSS-ECOMM-4_37): display product discount (#327) * feat: display product discount * fix: submit form addresses * feat: increase the interactive area of the description button on the product card * fix(RSS-ECOMM-4_96): cart blog footer (#328) * fix: color for dark theme * fix: subcategory link in footer navigation * fix: delete submit for subscribe button * fix: scroll after swipe * fix: price with discount for cart * fix: sort price and cart message * Merge branch 'sprint-4' into fix(RSS-ECOMM-4_96)/cartBlogFooter * refactor: delete comments * feat(RSS-ECOMM-4_37): update app themes (#329) * fix: replace notFound image * feat: implement redirection for unauth user * feat: translate app title * refactor: update setting app title * refactor: break down into smaller functions * refactor: update blog titles * feat: update themes colors * refactor: make two tumblers same size * fix: addresses colors * fix: footer logo margin * fix: discount label text color * feat(RSS-ECOMM-4_38): scroll to top button (#330) * feat: implement scrollToTop button * fix: binding context * refactor: update confirm component * refactor: update address edit buttons * fix: table heading color * refactor(RSS-ECOMM-4_39): search params (#331) * feat(RSS-ECOMM-4_95): add confirm and link (#333) * feat: add confirm and link * fix: cart request * refactor(RSS-ECOMM-4_40): update password edit form (#332) * refactor: replace div with form * feat: add mixin for repeated links * refactor: update footer links * fix: footer paddings * fix: add semantics to contact information * fix: add transition to blog articles shadow * refactor: replace to catalog link with mixin * refactor: discard redundant user check * chore: update CI/CD for sprint 5 * chore: solve conflicts * fix: after merge develop * fix: footer input not required * fix: validation params --------- Co-authored-by: Max <[email protected]> Co-authored-by: Yuliya Kursevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title ✨
📍 conforms with the following format:
feat
,fix
,hotfix
,chore
,refactor
,revert
,docs
,style
,test
)RSS-ECOMM-4_01
, where4
- is the sprint number and01
- is the issue number)👀 Example:
feat(RSS-ECOMM-4_01): description
PR Description 🧙♂️
Affected Scope 💡
Provide affected modules or areas
Styles 🎨
Provide any style changes details
Testing Strategy 🧼
Describe the testing strategy for the changes
Screenshots/Demo 📸
If necessary provide screenshots or a demo link to visually demonstrate the changes
Documentation Updates 📖
Specify if any documentation updates are required and provide details on what needs to be updated
Provide any other relevant information 🦉
Auto-Review 🤖
Self-Check 🌟