Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update production deploy with implemented features from [sprint_4] #334

Merged
merged 29 commits into from
Jun 3, 2024
Merged

chore: update production deploy with implemented features from [sprint_4] #334

merged 29 commits into from
Jun 3, 2024

Conversation

stardustmeg
Copy link
Owner

Sprint 4: Basket Page, Catalog Page Enhancements, and About Us Page Implementation 🚀

  1. Task Description 📑

  2. Screenshots: 📸
    image
    image
    image
    image
    image
    image

  3. Production Deployment 🥇
    Development Deployment 🚀

  4. Done 03/06/2024 ✅
    Deadline 18/06/2024 📆

5. 👨‍🏫 Mentor Evaluation Criteria (60 points - Total):

  • 🗣️ Code Review Participation (10 points): Students actively participate in code reviews, providing constructive feedback and suggestions to their peers.
  • ✅ No Merges Without Approvals (10 points): Pull requests are not merged without approvals from other team members, ensuring the quality of code contributions.
  • 📝 Pull Request Descriptions (10 points): Pull requests include detailed descriptions, outlining the changes made and the purpose of the changes, facilitating better understanding and review.
  • 🗒️ Task Board Management (10 points): Students maintain and regularly update a task board (e.g., Trello, Jira), ensuring that tasks are moved according to their progress and completion.
  • 💡 Active Participation in Development Discussions (5 points): Students take an active role in discussing the development process, sharing ideas, and collaborating on solutions and improvements.
  • 🧪 Unit Test Coverage (15 points): The codebase has a minimum of 25% unit test coverage, ensuring the reliability and robustness of the implemented features.

Penalties for Mentor Evaluation Criteria: ❌

  • N/A Linter Errors (5 points): If there are errors from the linter, a penalty of 5 points will be applied. Ensure that you follow the linter rules to maintain high code quality. 🛠️📝🛑
  • N/A Prettier Errors (5 points): If there are formatting errors detected by Prettier, a penalty of 5 points will be applied. It's important to adhere to established formatting conventions for clean, readable code. 📐✍️🛑
  • N/A Presence of 'any' (5 points): The use of 'any' in TypeScript can lead to potential typing issues and is generally discouraged. A penalty of 5 points will be applied if 'any' is found in the code. 🚫🔍🛑
  • N/A Non-functional Scripts in package.json (5 points): All scripts defined in the package.json should function correctly. If there are non-working scripts, a penalty of 5 points will be applied. ⚙️📦🛑
  • N/A Non-SPA Application (60 points): The application should be a Single Page Application (SPA) with an empty index.html. If this requirement is not met, a penalty of 60 points will be applied. ⚠️🖥️🛑

stardustmeg and others added 24 commits May 25, 2024 15:33
@stardustmeg
chore(RSS-ECOMM-4_00): update sprint number (#309)
1d57940 
chore: update sprint number
@stardustmeg @Kleostro @YulikK
refactor(RSS-ECOMM-4_30): update styles (#311)
275ba40 
refactor(RSS-ECOMM-3_58): separate styles in mixins (#310)

* docs(RSS-ECOMM-2_37): Update pipeline scripts and CD for a new sprint (#199)

* docs: update the PR template

* chore: add a job to generate PR titles

* chore: remove unnecessary paths from configs

* chore: remove unused package

* chore: remove a job from CI

* refactor(RSS-ECOMM-3_27): remove redundancies (#202)

* refactor: remove redundant tag constant

* refactor: replace redundant event names

* feat(RSS-ECOMM-3_03): add filters (#201)

* feat: add size product count request

* feat: add filter, edit sort, edit get product request

* feat: add search options

* refactor(RSS-ECOMM-2_53): registration form (#204)

* refactor: separate validators into separate functions

* refactor: separate address logic into Address component

* refactor: change getIsValid method

* fix: replace type for authCustomer method

* refactor: separate disabling into ButtonView

* fix: pattern for validate

* feat: types for Address component

* feat: create messageTemplate

* refactor: create every inputField separately

* refactor: create every inputField separately

* fix: header styles

* fix(RSS-ECOMM-2_54): visualisation forms (#206)

* fix: layout registration form

* fix: layout login form

* fix: layout address

* fix: layout countryChoice

* fix: layout login and registration pages

* refactor: remove the mandatory field symbol from field signatures in forms

* feat: add formatted text function

* fix: remove formatting from fields that should not be formatted

* feat: formatting of address fields

* refactor(RSS-ECOMM-2_55): router component (#207)

* refactor: rewrite Router component

* fix: navigation links

* fix: choosing country

* refactor: country lang choice based on input

* refactor: visual layout of pages

* fix: update store

* refactor: remove redundant code

* fix: styles

* feat: add init method for App component

* Apply suggestions from code review



---------



* feat(RSS-ECOMM-2_99): edit api client (#209)

feat: add save token, add auth and anonym client

* feat(RSS-ECOMM-3_29): pages lazy loading (#210)

* feat: implement lazy loading for pages

* fix: add a catch block

* feat(RSS-ECOMM-3_30): implement language switch (#212)

* feat: implement switching language on registration checkboxes

* feat: switch titles language

* feat: implement label text switching

* test: observe current language

* feat: add language choice to user messages

* fix: showPasswordElement position

* refactor: update text content in Russian

* feat: add a logo for language switch

* fix(RSS-ECOMM-3_31): rerouting to main (#213)

fix: rerouting to main

* feat(RSS-ECOMM-3_25): create pages components (#214)

* feat: add base page components

* docs: update PR template

* fix: link styles

* fix: button naming

* Apply suggestions from code review



---------



* feat(RSS-ECOMM-3_19): implement routing for all pages (#215)

feat: implement routing for all pages

* feat(RSS-ECOMM-3_21): implement navigation (#217)

* feat: implement navigation to catalog and cart pages

* fix: footer styles

* fix: header styles

* feat: implement navigation to other pages

* feat: check auth user to profile page

* feat: check auth user with init app

* feat: visually profile button

* feat(RSS-ECOMM-3_34): add catalog component (#218)

feat: add catalog component

* feat(RSS-ECOMM-3_33):  implement burger menu (#221)

feat: implement burger menu

* feat(RSS-ECOMM-3_01): implement product list (#223)

* refactor: api types

* feat: implement product list

* feat(RSS-ECOMM-3_36): implement theme app (#225)

* feat: implement app theme change

* feat: save current app theme in store

* fix: update store actions

* feat(RSS-ECOMM-3_02): display price and discount (#226)

* fix: api types for product

* feat: display price and discount on product card

* fix: rename SizeType

* feat(RSS-ECOMM-3_99): add blog page (#228)

* feat: add blog page

* feat: add blog page, posts, widget

* refactor: delete comment and magic numbers

* fix: mock data

* feat(RSS-ECOMM-3_03): implement filtering product list (#227)

* feat: expand loder options

* fix: styles product card

* feat: implement saving Set into LS Co-authored-by: Meg G. <[email protected]>

* feat: get and draw product items

* feat: create ProductFilters component

* feat: implement price filter

* feat: implement size filter

* feat: filters reset button

* fix: burger styles

* fix: lost title

* feat(RSS-ECOMM-3_98): add all data in one request (#229)

* feat: add all data in one request

* feat: add refresh token, fix auth, refactor client

* fix(RSS-ECOMM-3_40): handle popstate event (#231)

fix: handle popstate event

* feat(RSS-ECOMM-3_37): implement switching user locale (#233)

* feat: add a user notification on switching language

* feat: implement switching locale

* feat(RSS-ECOMM-3_97): add filter Object, make filer with OR concatenation (#230)

* feat: add filter Object, make filer with OR concatenation

* refactor: delete comment

* feat: add categoryCount and SizeCount to Products response

* feat(RSS-ECOMM-3_03): implement meta filters (#235)

* fix: router

* feat: implement meta filters

* Apply suggestions from code review



---------



* test(RSS-ECOMM-3_24): cover main codebase (#236)

test(RSS-ECOMM-3_24): cover main codebase

* refactor(RSS-ECOMM-3_41): logic input components (#237)

* feat: create method to add data attributes for input

* refactor: remove unused data for creating input fields

* refactor: delete unused options for address component

* feat(RSS-ECOMM-3_14): display user info (#234)

* feat: add user info menu

* refactor: replace recurring code with a util function

* feat: add common utils

* feat: display user info

* refactor: remove the language switch

* chore: complete merge

* refactor: remove sending request until user is logged in on refresh

* refactor: move language choice from buttons constants

* feat: add modal

* fix: remove unused var

* fix: modal styles

* feat: create separate entities for user info and user addresses

* refactor: remove redundant code

* refactor: add comments

* feat(RSS-ECOMM-3_04): implement product sorts (#238)

* chore: integrate plop to create component folder

* chore: add templates folder

* docs: update readme

* chore: update configs

* chore: update configs

* feat: implement products sorting

* Apply suggestions from code review



* fix: after merge

---------



* feat(RSS-ECOMM-3_96): add cart and shop list (#239)

* feat: add cart, refactor root, delete product from store

* feat: add and delete cart item

* feat: add anonymId to store, merge anonym cart after login user

* feat: create create for new customer, getCart

* feat: add shoppingList

* feat: create shopping list after registration

* feat: getCategories function

* feat(RSS-ECOMM-3_95): add price range (#240)

feat: add price range

* feat(RSS-ECOMM-3_42): transfer styles to clamp (#242)

* refactor: transfer to clamp

* refactor: remove background with unused pictures

* refactor: remove commented out code

* chore(RSS-ECOMM-3_43): modernise the creation of a component via plopfile (#243)

chore: modernise the creation of a component via plopfile

* chore(RSS-ECOMM-3_44): update display select list in terminal (#244)

chore: update display select list in terminal

* fix(RSS-ECOMM-3_45): styles (#245)

* fix: sorting wrapper style

* fix: error and burger z-indices

* chore(RSS-ECOMM-3_45): update readme (#246)

* docs: update readme

* chore: update vite configs to minify build code

* fix: typo

* feat(RSS-ECOMM-3_05): implement product search (#247)

* feat: create product search component

* feat: implement product search

* feat(RSS-ECOMM-3_94): update user addresses; save token to store (#248)

* feat: move save token from cook to store

* feat: add shipping billing address to user

* feat(RSS-ECOMM-3_46): implement custom scroll (#249)

feat: implement custom scroll

* fix(RSS-ECOMM-3_47): display products with selected filters (#250)

fix: display products with selected filters

* feat(RSS-ECOMM-3_94): add id filter for products (#251)

feat: add id filter for products

* feat(RSS-ECOMM-3_48): implement buttons to product card (#252)

* feat: implement buttons to product card

* feat: getters

* feat(RSS-ECOMM-3_48): translate filters, sorting and search (#254)

feat: translate filters, sorting and search

* feat(RSS-ECOMM-3_49): add product to cart and wishlist (#255)

feat: add product to cart and wishlist

* fix(RSS-ECOMM-3_50): incoming product card parameters (#256)

* fix: incoming product card parameters

* fix: catalog styles

* feat(RSS-ECOMM-3_93): add getCurrentUser (#257)

feat: add getCurrentUser

* fix(RSS-ECOMM-3_51): router component (#258)

* fix: routing to detailed product page

* fix: redirect to default page

* feat(RSS-ECOMM-3_92): add parent to category (#260)

* refactor(RSS-ECOMM-3_52): router component (#261)

* refactor: get rid of asynchronous methods in the router

* refactor: add / at the end of each route

* feat: add search queries to url

* fix: router test

* fix: update netlify

* fix: update netlify

* fix: update netlify

* fix: update netlify

* fix: router

* fix: router

* feat(RSS-ECOMM-3_91): update auth client after password change (#263)

feat: update auth client after password change

* feat(RSS-ECOMM-3_91): add slug for category and product (#262)

feat: add slug for category and product

* feat(RSS-ECOMM-3_15): update user info (#253)

* refactor: separate PersonalInfoComponent

* refactor: separate credentials into a single component

* refactor: remove user from store

* feat: add a request before showing personal info

* feat: implement changing password

* fix: switch language for anonymous user

* refactor: create one instance of modal content

* fix: navigation styles

* fix: redirect to main on logo

* feat(RSS-ECOMM-3_08): implement breadcrumb navigation (#289)

* feat: implement event mediator component

* feat: implement search params in url

* refactor: remove user from state

* feat: implement breadcrumbs

* Update src/shared/constants/sorting.ts



* fix: prettier

---------



* feat(RSS-ECOMM-3_09): display product details on product page (#294)

feat: display product details on product page

* feat(RSS_ECOMM-3_90): add key request (#295)

feat: add key request

* feat(RSS-ECOMM-3_89): add adapt Product (#296)

feat: add adapt Product

* feat(RSS-ECOMM-3_10): implement slider on product page (#297)

feat: implement slider on product page

* fix(RSS-ECOMM-3_53): routing on product page (#298)

* fix: routing on product page

* fix: search params

* feat(RSS-ECOMM-3_13): implement product modal slider (#299)

feat: implement product modal slider

* feat(RSS-ECOMM-3_90) cart (#300)

* feat: add cart page

* feat: badge for cart

* feat: add actions for cart products

* feat: merge cart after registration

* feat(RSS-ECOMM-3_16): implement personal info edit (#301)

* feat: close modal on click on background

* feat: implement personal info edit

* feat: implement changing component styles

* refactor(RSS-ECOMM-3_54): router component (#303)

* refactor: make Router singleton

* refactor: remove redundant router field

* feat: separate product price in component

* refactor: styles

* Apply suggestions from code review



* fix: prettier

---------



* feat(RSS-ECOMM-4_08): implement cart button to product page (#304)

* feat: add modal window closing on click outside the window

* feat: add a modal window with product details

* feat: add loader in product modal slider

* feat: implement cart button to product page

* Apply suggestions from code review



---------



* fix(RSS-ECOMM-3_55): deploy (#305)

fix: deploy

* feat(RSS-ECOMM-3_56): add progress bar to server message (#307)

feat: add progress bar to server message

* refactor: separate style buttons in mixin

* fix: delete navigation from footer

---------

Co-authored-by: Max <[email protected]>
Co-authored-by: Yuliya Kursevich <[email protected]>
@YulikK
feat(RSS-ECOMM-4_99): add navigate and languages to footer (#312)
b8e23ec 
* feat: add navigate and languages

* feat: translate for social and pay

* feat: styles
@Kleostro
feat(RSS-ECOMM-4_31): adaptive (#314)
20ec774 
* feat: add scroll top on every page

* feat: adaptive noUiSlider

* feat: add adaptive up to 380px
@YulikK
feat(RSS-ECOMM-4_98): add level to product (#313)
43da852 
feat: add level to product
@YulikK
feat(RSS-ECOMM-4_97): add address actions (#315)
cfd3da8 
feat: add address actions
@YulikK
feat(RSS-ECOMM-4_96): add total count for products (#316)
5a0e33a 
feat: add total count for products
@Kleostro
feat(RSS-ECOMM-4_03): implement effecting loading products (#318)
7cfd176 
* feat: separate control search params in router

* feat: add pagination component

* refactor: remove redundant fields in store
@Kleostro
feat(RSS-ECOMM-4_32): display difficultyPlants (#319)
2435860 
* feat: display difficultyPlants

* fix: position difficulty plants
@stardustmeg
feat(RSS-ECOMM-3_18): implement addresses management (#317)
7b6e156 
* feat: implement adding address

* feat: implement adding billing and shipping address

* feat: add default address

* feat: add styles to add address form

* feat: add mixins

* feat: implement deleting address

* refactor: add error message to a message notification

* refactor: remove determining address type to a separate function

* feat: implement redrawing after changes

* fix: determine address type
@Kleostro
fix(RSS-ECOMM-4_33): reloading product page (#320)
5c48af6 
fix: reloading product page
@YulikK
feat(RSS-ECOMM-4_10)/cart (#321)
b6c685f 
* feat: modify quantity

* feat: delete button for mobile

* feat: add clear cart

* feat: language and message

* fix: src img
@YulikK
feat(RSS-ECOMM-4_97): filter range (#323)
20fedc3 
* feat: filter Type

* feat: catalog filter

* feat: filter price range
@stardustmeg
feat(RSS-ECOMM-4_33): implement editing address (#322)
5677dfe 
* feat: implement Confirm component

* fix: styles for responsive

* feat: add confirmation message

* fix: dark theme variable

* feat: implement changing address fields

* feat: add styles to edit address window

* feat: add remove content method to modal
@Kleostro
fix(RSS-ECOMM-4_34): catalog (#324)
014986d 
* fix: country validation

* fix: last link in breadcrumbs

* fix: range price slider
@stardustmeg
feat(RSS-ECOMM-4_35): update address editing (#325)
77232bf 
* feat: update errorMessage to include a custom message

* feat: update edit to remove default only

* fix: typo in title

* feat: add loader for address request

* refactor: replace bin picture
@Kleostro
fix(RSS-ECOMM-4_36): user addresses (#326)
8811d8d 
* fix: validation postal code

* fix: display user addresses
@Kleostro
feat(RSS-ECOMM-4_37): display product discount (#327)
44d3edf 
* feat: display product discount

* fix: submit form addresses

* feat: increase the interactive area of the description button on the product card
@YulikK
fix(RSS-ECOMM-4_96): cart blog footer (#328)
9f8a8a7 
* fix: color for dark theme

* fix: subcategory link in footer navigation

* fix: delete submit for subscribe button

* fix: scroll after swipe

* fix: price with discount for cart

* fix: sort price and cart message

* Merge branch 'sprint-4' into fix(RSS-ECOMM-4_96)/cartBlogFooter

* refactor: delete comments
@stardustmeg
feat(RSS-ECOMM-4_37): update app themes (#329)
c1e9264 
* fix: replace notFound image

* feat: implement redirection for unauth user

* feat: translate app title

* refactor: update setting app title

* refactor: break down into smaller functions

* refactor: update blog titles

* feat: update themes colors

* refactor: make two tumblers same size

* fix: addresses colors

* fix: footer logo margin

* fix: discount label text color
@stardustmeg
feat(RSS-ECOMM-4_38): scroll to top button (#330)
1b45d94 
* feat: implement scrollToTop button

* fix: binding context

* refactor: update confirm component

* refactor: update address edit buttons

* fix: table heading color
@Kleostro
refactor(RSS-ECOMM-4_39): search params (#331)
39d0992
@YulikK
feat(RSS-ECOMM-4_95): add confirm and link (#333)
334dd1b 
* feat: add confirm and link

* fix: cart request
@stardustmeg
refactor(RSS-ECOMM-4_40): update password edit form (#332)
2040aa7 
* refactor: replace div with form

* feat: add mixin for repeated links

* refactor: update footer links

* fix: footer paddings

* fix: add semantics to contact information

* fix: add transition to blog articles shadow

* refactor: replace to catalog link with mixin

* refactor: discard redundant user check

* chore: update CI/CD for sprint 5
@netlify Netlify
Copy link

netlify bot commented Jun 3, 2024 •
edited
Loading

✅ Deploy Preview for mad-wizards-greenshop ready!

Name Link
🔨 Latest commit 27c217c
🔍 Latest deploy log https://app.netlify.com/sites/mad-wizards-greenshop/deploys/665e3c6691005500085c21c2
😎 Deploy Preview https://deploy-preview-334--mad-wizards-greenshop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation test style labels Jun 3, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 3, 2024 •
edited
Loading

✅ Deploy Preview for mad-wizards-greenshop-develop ready!

Name Link
🔨 Latest commit 27c217c
🔍 Latest deploy log https://app.netlify.com/sites/mad-wizards-greenshop-develop/deploys/665e3c664510890008eca952
😎 Deploy Preview https://deploy-preview-334--mad-wizards-greenshop-develop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stardustmeg stardustmeg requested a review from MikAleinik June 3, 2024 21:54
@stardustmeg stardustmeg merged commit 0a0d5e1 into develop Jun 3, 2024
11 checks passed
This was linked to issues Jun 3, 2024
[sprint_3] Cross-check Submit 🌟 #169
Closed
[sprint_3] Mentor Submit 🌟 #170
Closed
[sprint_4] Mentor Submit 🌟 #293
Closed
@stardustmeg stardustmeg mentioned this pull request Jun 3, 2024
Open
21 tasks
@stardustmeg stardustmeg deleted the sprint-4 branch June 3, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikAleinik MikAleinik MikAleinik approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation mentor 👨‍🏫 sprint4 🧺 style test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sprint_4] Mentor Submit 🌟 [sprint_3] Mentor Submit 🌟 [sprint_3] Cross-check Submit 🌟
4 participants
@stardustmeg @MikAleinik @YulikK @Kleostro