Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(RSS-ECOMM-5_18): router #358

Merged
merged 2 commits into from
Jun 10, 2024
Merged

refactor(RSS-ECOMM-5_18): router #358

merged 2 commits into from
Jun 10, 2024

Conversation

Kleostro
Copy link
Collaborator

@Kleostro Kleostro commented Jun 10, 2024 •
edited
Loading

PR Title ✨

📍 conforms with the following format:

  • prefix (following the convention: feat, fix, hotfix, chore, refactor, revert, docs, style, test)
  • sprint and issue number (e.g. RSS-ECOMM-5_01, where 5 - is the sprint number and 01 - is the issue number)
  • short description

👀 Example: feat(RSS-ECOMM-5_01): description

PR Description 🧙‍♂️

  • Put methods for search parameters into separate helper functions.
  • Use key instead of id to display categories in URL.

Auto-Review 🤖

  • The reviewers have been requested 📝
    Request Review on PR Open
  • The labels have been added 🎨
    Pull Request Labeler
  • My code doesn't generate any errors or warnings ⛓️
    Continuous Integration
  • My code builds successfully ⚙️
    Netlify Status

Self-Check 🌟

  • I wrote the correct title for the PR 🗝️
  • I wrote a comprehensive description for the PR 📜
  • I have performed a self-review of my own code ✅
  • I have commented my code where needed 📝
  • I am happy with my PR and ready to merge ❤️‍🔥

@netlify Netlify
Copy link

netlify bot commented Jun 10, 2024 •
edited
Loading

✅ Deploy Preview for mad-wizards-greenshop-develop ready!

Name Link
🔨 Latest commit 42cf994
🔍 Latest deploy log https://app.netlify.com/sites/mad-wizards-greenshop-develop/deploys/666699770fb286000820fe71
😎 Deploy Preview https://deploy-preview-358--mad-wizards-greenshop-develop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot requested review from stardustmeg and YulikK June 10, 2024 06:13
@Kleostro
Copy link
Collaborator Author

[sprint_5] Issue RSS-ECOMM-5_09: Новый фильтра, категории по кей

stardustmeg
stardustmeg approved these changes Jun 10, 2024
View reviewed changes
Copy link
Owner

@stardustmeg stardustmeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👏 Thanks ❤️‍🔥

@Kleostro Kleostro merged commit fd6c1b5 into sprint-5 Jun 10, 2024
8 checks passed
@Kleostro Kleostro deleted the refactor(RSS-ECOMM-5_18)/router branch June 10, 2024 06:23
stardustmeg added a commit that referenced this pull request Jun 17, 2024
@stardustmeg @Kleostro @YulikK
feat: update latest prod state with [sprint-4] (#373)
371aabe 
* fix(RSS-ECOMM-5_01): breadcrumbs text (#336)

fix: breadcrumbs text

* fix(RSS-ECOMM-5_02): footer subscribe form (#337)

* fix: footer subscribe form

* fix: styles

* feat(RSS-ECOMM-4_16): display promo on main page (#338)

feat: display promo on main page

* fix(RSS-ECOMM-5_03): display promo slider (#340)

* fix: display promo slider

* Apply suggestions from code review

Co-authored-by: Meg G. <[email protected]>

---------

Co-authored-by: Meg G. <[email protected]>

* feat(RSS-ECOMM-5_04): formatted time function (#341)

feat: formatted time function

* feat(RSS-ECOMM-5_06): implement cooperation page (#342)

feat: implement cooperation page

* feat(RSS_ECOMM-5_99): blog carts (#339)

* feat: blog img

* refactor: move blog to folders

* refactor: cart handler with bind

* feat: loader in center button

* fix: cart error

* feat: min for blog

* fix: anonymous cart error

* feat(RSS-ECOMM-5_07): add details to user messages (#343)

* feat: add details to user messages

* feat: add a link to cooperation page

* feat(RSS-ECOMM-5_08): update post description (#344)

* feat: update clamp default size

* feat: update posts descriptions

* refactor(RSS-ECOMM-5_09): separate wishlist button into component (#345)

* refactor: separate wishlist button into component

* fix: remove cooperation json

* feat(RSS-ECOMM-5_10): pagination in catalog bottom (#346)

feat: pagination in catalog bottom

* feat(RSS-ECOMM-5_12): implement wishlist page (#347)

feat: implement wishlist page

* refactor(RSS-ECOMM-5_13): wishlist (#348)

* refactor(RSS-ECOMM-5_14): wishlist and catalog pages (#349)

* refactor: replace params in product price component

* fix: request products

* refactor: make utilities for url construction

* feat(RSS-ECOMM-5_98)/coupon product (#350)

* feat(RSS-ECOMM-5_11): translate breadcrumbs (#351)

* fix: cart table header styles

* fix: footer styles

* feat: translate breadcrumbs

* refactor: product page model component

* feat: add scroll to top on pagination click

* refactor: replace header heart svg

* feat: translate wishlist breadcrumbs

* refactor: remove unnecessary check

* refactor(RSS-ECOMM-5_15): breadcrumbs rendering (#352)

refactor: breadcrumb rendering

* fix(RSS-ECOMM-5_97): shopList error (#354)

fix: shopList error

* refactor(RSS-ECOMM-5_16): link slider and url (#353)

refactor: link slider and url

* refactor(RSS-ECOMM-5_17):  display product slider on product page and modal (#356)

* feat(RSS-ECOMM-5_96): delete coupons (#357)

* feat: delete coupons

* feat: add message after delete coupon

* refactor(RSS-ECOMM-5_18): router (#358)

* refactor: put methods for search parameters into separate helper functions

* refactor: use key instead of id to display categories in URL

* feat(RSS-ECOMM-5_96): update requests (#355)

* feat: add sale category request

* feat: filter *

* feat: options for shop list

* feat: merge

* feat(RSS-ECOMM-5_95): promo code banner (#359)

* feat: promo code banner

* fix: theme and birthday title

* feat: optimization png

* feat: img webp

* refactor(RSS-ECOMM-5_19): move cart and wishlist to top header (#360)

refactor: move cart and wishlist to top header

* feat(RSS-ECOMM-5_94): cart styles (#362)

* feat: cart styles

* feat: resize cart

* feat: style total

* refactor(RSS-ECOMM-5_20): refactor main codebase (#361)

* refactor: add a utility function to get current language

* refactor: remove redundant store calls

* refactor: separate count badge into a separate component

* refactor: update discount label text

* feat: implement wishlist count badge

* feat: implement wishlist count badge

* fix: confirm message background

* feat(RSS-ECOMM-5_93): birthday check (#363)

feat: birthday check

* feat(RSS-ECOMM-5_93): link cart (#364)

* feat: link name

* refactor: delete comment

* refactor(RSS-ECOMM-5_21): implement separate page for addresses (#365)

* feat: implement separate page for addresses

* refactor: update user info styles

* feat: update user profile styles

* refactor(RSS-ECOMM-5_22): update Not Found page (#366)

refactor: update Not Found page

* feat(RSS-ECOMM-5_19): implement about us page (#367)

* fix: year at the promo code

* feat: implement about us page

* feat(RSS-ECOMM-5_20): rss logo (#369)

feat: rss logo

* feat(RSS-ECOMM-5_90: test for api and components (#370)

* feat: test for api and components

* feat: remove comments remove singleton api obj

* refactor(RSS-ECOMM-5_23): remove unused elements (#368)

* refactor: remove unused utility functions

* refactor: remove unused constants

* refactor: update edit info styles

* refactor: move tuumblers styles to mixins

* fix: header arrow button position

* fix: update text content

* feat: add difficulty description tooltip

* fix: update cart no items text

* feat(RSS-ECOMM-5_24): add mentor's photo (#371)

feat: add mentor's photo

* fix(RSS-ECOMM-5_25): modal close (#372)

fix: modal close

---------

Co-authored-by: Max <[email protected]>
Co-authored-by: Yuliya Kursevich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stardustmeg stardustmeg stardustmeg approved these changes

@YulikK YulikK Awaiting requested review from YulikK

Assignees
No one assigned
Labels
refactor sprint5 style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kleostro @stardustmeg