Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(RSS-ECOMM-1_44): write tests for basic components #73

Merged
merged 7 commits into from
Apr 28, 2024

Conversation

Kleostro
Copy link
Collaborator

@Kleostro Kleostro commented Apr 28, 2024

PR Title ✨

πŸ“ conforms with the following format:

  • prefix (following the convention: feat, fix, hotfix, chore, refactor, revert, docs, style, test)
  • sprint and issue number (e.g. RSS-ECOMM-1_01, where 1 - is the sprint number and 01 - is the issue number)
  • short description

πŸ‘€ Example: feat(RSS-ECOMM-1_01): description

PR Description πŸ§™β€β™‚οΈ

  • Add tests for Button and Input components.
  • Add tests for utils functions.
  • Add tests for Store component.

Self-Check 🌟

  • I wrote the correct title for the PR πŸ—οΈ
  • I wrote the correct description for the PR πŸ“œ
  • I have performed a self-review of my own code βœ…
  • I have commented my code where needed πŸ“
  • My code is formatted correctly and passes the check 🎨
  • My code passes the tests check ⛓️
  • My code successfully builds βš™οΈ
  • I am happy with my PR and ready to merge ❀️‍πŸ”₯

Copy link

netlify bot commented Apr 28, 2024

βœ… Deploy Preview for mad-wizards-greenshop ready!

Name Link
πŸ”¨ Latest commit da1faff
πŸ” Latest deploy log https://app.netlify.com/sites/mad-wizards-greenshop/deploys/662ee16ae3a4510008b167e3
😎 Deploy Preview https://deploy-preview-73--mad-wizards-greenshop.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@stardustmeg stardustmeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing ❀️‍πŸ”₯

@Kleostro Kleostro merged commit 7e1f144 into develop Apr 28, 2024
7 checks passed
@Kleostro Kleostro deleted the test(RSS-ECOMM-1_44)/writeTestsForBasicComponents branch April 28, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants