Improve meson build #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antolius
requested changes
Feb 5, 2022
| @@ -1,4 +1,4 @@ | |||
| <img align="left" width="64" height="64" src="https://raw.githubusercontent.com/starfish-app/starfish/main/data/icons/64.svg"> | |||
| <img align="left" width="64" height="64" src="https://raw.githubusercontent.com/starfish-app/starfish/main/data/icons/64/hr.from.josipantolis.starfish.svg"> | |||
There was a problem hiding this comment.
I'd prefer not to have project name repeated in too many places, such as icon file names, etc.
Ideally it would only be defined in the project function call on top of the root meson.build file.
Individual files can be renamed in calls to install_data function. That approach allows for:
- Shorter file names without repetition. This just makes working with them more comfortable.
- Easier rename of the project in the future. Either if someone wanted to maintain a fork long term, or just easily install 2 versions on the same system.
Admittedly, I haven't followed this rule in all the places myself, but I plan to clean those up over time.
| @@ -89,7 +89,7 @@ flatpak run hr.from.josipantolis.starfish | |||
|
|
|||
| ## License | |||
|
|
|||
| [GNU GPLv3](COPYING) | |||
| [GNU GPLv3](LICENSE) | |||
There was a problem hiding this comment.
I think COPYING is the standard / recommended name for the file containing the full GPL license text.
I'd like to stay aligned with that standard.
| 'test/Core/GeminiBodyTest.vala', | ||
| 'test/Core/UriTest.vala' | ||
| # Compiling resources | ||
| gresource = gnome.compile_resources ( |
There was a problem hiding this comment.
Would it make sense to move this into data/meson.build as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few improvements to your app structure. These are not breaking changes. Let me know if you have any questions 😄
Changelog:
COPYINGtoLICENSEmeson.buildfilesmeson.buildfilespost_install.pyscriptI would be happy to add French translation once this will have been reviewed
I tried to build and run the app locally using both meson and flatpak and I had no issues