Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nuke starknet-types-rpc crate #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tdelabro
Copy link
Collaborator

Nobody is using this crate. We are nuking it and abandoning support for it.

@antiyro
Copy link
Collaborator

antiyro commented Jan 24, 2025

That's unfortunate and I still believe we should have proper maintainers on this repo, but if this is approved then we'll make sure to add clear native support in Madara. Thanks @tdelabro for handling this.

Copy link
Collaborator

@antiyro antiyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@antiyro
Copy link
Collaborator

antiyro commented Jan 24, 2025

We should make sure this doesn't break any projects, but anyway, they would need to manifest themselves somewhere, like we did for Madara with the upcoming v0.8.0

Capture d’écran 2025-01-24 à 15 53 54

Copy link
Collaborator

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kaboom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants