Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Felt from boolean #24

Merged
merged 15 commits into from
Dec 20, 2023
Merged

Implement Felt from boolean #24

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
053ed0f
Implement felt to bigint functions
pefontana Dec 11, 2023
40d99fa
remove mod
pefontana Dec 11, 2023
ebfebde
Add tests
pefontana Dec 11, 2023
4bc8a5d
Implement Felt from bool
pefontana Dec 12, 2023
8242410
Merge branch 'main' into felt-to-bigint
pefontana Dec 15, 2023
ea4166a
use lazy_static spin_no_std feature
pefontana Dec 15, 2023
7baf947
Merge branch 'felt-to-bigint' into bool-to-felt
pefontana Dec 15, 2023
360e50a
Merge branch 'main' into felt-to-bigint
pefontana Dec 18, 2023
3397b48
impl From<&BigInt> for Felt
pefontana Dec 18, 2023
0491cdc
impl From<&BigUint> for Felt
pefontana Dec 18, 2023
8a86316
impl Felt.to_biguint() method
pefontana Dec 18, 2023
dd7580e
impl Felt.to_bigint() method
pefontana Dec 18, 2023
29f0b9d
remove unwrap
pefontana Dec 19, 2023
b4f7d07
Merge branch 'felt-to-bigint' into bool-to-felt
pefontana Dec 19, 2023
3ccaffb
Merge branch 'main' into bool-to-felt
pefontana Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions crates/starknet-types-core/src/felt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,15 @@ impl From<i128> for Felt {
}
}

impl From<bool> for Felt {
fn from(value: bool) -> Felt {
match value {
true => Felt::ONE,
false => Felt::ZERO,
}
}
}

impl From<&BigInt> for Felt {
fn from(bigint: &BigInt) -> Felt {
let (sign, bytes) = bigint.mod_floor(&CAIRO_PRIME_BIGINT).to_bytes_le();
Expand Down Expand Up @@ -1715,4 +1724,12 @@ mod test {
);
}
}

#[test]
fn bool_into_felt() {
let zero: Felt = false.into();
let one: Felt = true.into();
assert_eq!(one, Felt::ONE);
assert_eq!(zero, Felt::ZERO);
}
}