LS: Proc macro - scarb code

[Draggu]

Code calling dylib is replaced with one calling proc-macro-server. Also aux_data is removed as it is useless for LS.

---

Stack:

• LS: Proc macro disable option in config #6706
• LS: Proc macro server failed notification #6705
• LS: Proc macro handle responses #6704
• LS: Proc macro - scarb code #6638 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[piotmag769]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @mkaput, and @orizi)

---

crates/cairo-lang-language-server/src/lang/proc_macros/plugins/scarb/regular.rs line 30 at r1 (raw file):

}

fn calculate_metadata(db: &dyn SyntaxGroup, item_ast: ast::ModuleItem) -> TokenStreamMetadata {

This should be lower (public first)

[Draggu]

Reviewable status: 3 of 7 files reviewed, all discussions resolved (waiting on @Arcticae, @mkaput, @orizi, and @piotmag769)

---

crates/cairo-lang-language-server/src/lang/proc_macros/plugins/scarb/regular.rs line 30 at r1 (raw file):

Previously, piotmag769 (Piotr Magiera) wrote…

This should be lower (public first)

Done.

[piotmag769]

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @mkaput, and @orizi)

[mkaput]

Reviewed 1 of 2 files at r4, all commit messages.
Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @orizi, and @piotmag769)

---

crates/cairo-lang-language-server/Cargo.toml line 29 at r4 (raw file):

cairo-lang-utils = { path = "../cairo-lang-utils", version = "~2.8.4" }
cairo-lang-macro = "0.1.1"
# Used in proc-macro code copied from scarb.

These comments are unnecessary imho: if we use these deps, then we use them, and comments break easily sorting deps

[Draggu]

Reviewable status: 3 of 7 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @mkaput, @orizi, and @piotmag769)

---

crates/cairo-lang-language-server/Cargo.toml line 29 at r4 (raw file):

Previously, mkaput (Marek Kaput) wrote…

These comments are unnecessary imho: if we use these deps, then we use them, and comments break easily sorting deps

Done.

[Arcticae]

Reviewed 1 of 4 files at r2, 2 of 2 files at r4.
Reviewable status: 4 of 7 files reviewed, 5 unresolved discussions (waiting on @Draggu, @mkaput, @orizi, and @piotmag769)

---

crates/cairo-lang-language-server/src/lang/proc_macros/plugins/scarb/inline.rs line 12 at r4 (raw file):

use crate::lang::proc_macros::db::ProcMacroCacheGroup;

// scarb code

I would mark where it comes from, for easier exploration and maintainability (perhaps a git permalink also would be nice)

---

crates/cairo-lang-language-server/src/lang/proc_macros/plugins/scarb/mod.rs line 11 at r4 (raw file):

pub mod regular;

// Code from scarb.

Same as above

---

crates/cairo-lang-language-server/src/lang/proc_macros/plugins/scarb/regular.rs line 20 at r4 (raw file):

use crate::lang::proc_macros::db::ProcMacroCacheGroup;

// scarb code

Same as above

---

crates/cairo-lang-language-server/src/lang/proc_macros/plugins/mod.rs line 12 at r4 (raw file):

// Keep it private.
mod downcast;
// Code from scarb.

Let's not describe it on import

[orizi]

Reviewed 1 of 1 files at r3, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @Draggu and @mkaput)

[Draggu]

Reviewable status: 3 of 7 files reviewed, 5 unresolved discussions (waiting on @Arcticae, @integraledelebesgue, @mkaput, and @piotmag769)

---

crates/cairo-lang-language-server/src/lang/proc_macros/plugins/mod.rs line 12 at r4 (raw file):

Previously, Arcticae (Tomasz Rejowski) wrote…

Let's not describe it on import

I believe this was comment to previous comment.

---

crates/cairo-lang-language-server/src/lang/proc_macros/plugins/scarb/inline.rs line 12 at r4 (raw file):

Previously, Arcticae (Tomasz Rejowski) wrote…

I would mark where it comes from, for easier exploration and maintainability (perhaps a git permalink also would be nice)

Done.

---

crates/cairo-lang-language-server/src/lang/proc_macros/plugins/scarb/mod.rs line 11 at r4 (raw file):

Previously, Arcticae (Tomasz Rejowski) wrote…

Same as above

Done.

---

crates/cairo-lang-language-server/src/lang/proc_macros/plugins/scarb/regular.rs line 20 at r4 (raw file):

Previously, Arcticae (Tomasz Rejowski) wrote…

Same as above

Done.

[mkaput]

Reviewed 2 of 7 files at r6, 1 of 1 files at r7, 4 of 4 files at r8, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Arcticae and @integraledelebesgue)

[Arcticae]

Reviewed 1 of 4 files at r8.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @integraledelebesgue)

[mkaput]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @integraledelebesgue)

[mkaput]

Reviewed 2 of 2 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @integraledelebesgue)

[mkaput]

Reviewed 2 of 2 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @integraledelebesgue)

[piotmag769]

Reviewed 3 of 4 files at r8, 1 of 2 files at r9, 2 of 2 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved