LS: Refactor DiagnosticsController

[mkaput]

This commit prepares DiagnosticsController
for adding multithreaded processing.

1. DiagnosticsController::refresh takes shared reference to owned
   state and makes snapshots internally.
2. Encapsulated controller thread state into a struct.
3. Notifier and file_diagnostics are now stored in controller's
   state instead of being passed around.
4. Some minor renames and doc rewordings.

---

Stack:

• LS: Implement multithreaded diagnostics refreshing #6658
• LS: Refactor DiagnosticsController #6657 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[piotmag769]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @orizi)

[Arcticae]

Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Draggu and @orizi)

[Arcticae]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Draggu and @orizi)

[Draggu]

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @mkaput and @orizi)

---

crates/cairo-lang-language-server/src/lang/diagnostics/mod.rs line 32 at r2 (raw file):

    //   Otherwise, the controller thread will never be requested to stop, and the controller's
    //   JoinHandle will never terminate.
    trigger: trigger::Sender<StateSnapshot>,

How do you plan making multiple snapshots from this? salsa snapshot is !Clone and can only be made from db itself, not another snapshot, as so we must prepare N snapshots on LS main thread so we can distribute them here.

[mkaput]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @Draggu, @orizi, and @piotmag769)

---

crates/cairo-lang-language-server/src/lang/diagnostics/mod.rs line 32 at r2 (raw file):

Previously, Draggu (Piotr Figiela) wrote…

How do you plan making multiple snapshots from this? salsa snapshot is !Clone and can only be made from db itself, not another snapshot, as so we must prepare N snapshots on LS main thread so we can distribute them here.

See how I did it in #6658

[Draggu]

Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @orizi and @piotmag769)

---

crates/cairo-lang-language-server/src/lang/diagnostics/mod.rs line 32 at r2 (raw file):

Previously, mkaput (Marek Kaput) wrote…

See how I did it in #6658

Ok, I see, description is confusing.

---

-- commits line 9 at r3:
If you are doing this in next PR please move it to mentioned PR.

[mkaput]

Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @orizi and @piotmag769)

---

-- commits line 9 at r3:

Previously, Draggu (Piotr Figiela) wrote…

If you are doing this in next PR please move it to mentioned PR.

you mean moving the description?

i changed signature here because it breaks diff for next PR (marks too much code as diffing)

[Draggu]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @mkaput, @orizi, and @piotmag769)

---

-- commits line 9 at r3:

you mean moving the description?

Yes, it states that making N snapshots is done here while it is not.

[mkaput]

Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @orizi and @piotmag769)

---

-- commits line 9 at r3:

Previously, Draggu (Piotr Figiela) wrote…

you mean moving the description?

Yes, it states that making N snapshots is done here while it is not.

Done