Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added closures to protected zone #7065

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

dean-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@dean-starkware dean-starkware marked this pull request as ready for review January 13, 2025 09:45
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @dean-starkware and @orizi)


crates/cairo-lang-formatter/test_data/expected_results/linebreaking.cairo line 172 at r1 (raw file):

        sixth_arg: T,
        seventh_arg: T,
    | {

Now I'm not sure about the change, let's discuss.

Code quote:

    let foo = |
        first_arg: T,
        second_arg: T,
        third_arg: T,
        fourth_arg: T,
        fifth_arg: T,
        sixth_arg: T,
        seventh_arg: T,
    | {

@dean-starkware dean-starkware force-pushed the dean/formatter_closures_protected_zone branch from 14940a6 to 6d4dcc8 Compare January 13, 2025 11:10
Copy link
Collaborator Author

@dean-starkware dean-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @orizi)


crates/cairo-lang-formatter/test_data/expected_results/linebreaking.cairo line 172 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Now I'm not sure about the change, let's discuss.

I prefer it this way. It's more consistent- aligned with the recent closure fix we just implemented.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


crates/cairo-lang-formatter/test_data/expected_results/linebreaking.cairo line 172 at r1 (raw file):

Previously, dean-starkware wrote…

I prefer it this way. It's more consistent- aligned with the recent closure fix we just implemented.

looks much better to my eyes.

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dean-starkware)

@dean-starkware dean-starkware added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit ec1caa6 Jan 13, 2025
48 checks passed
@orizi orizi linked an issue Jan 14, 2025 that may be closed by this pull request
@orizi orizi deleted the dean/formatter_closures_protected_zone branch January 15, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Inconsistent scarb fmt Behavior for Closures
4 participants