-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added closures to protected zone #7065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @dean-starkware and @orizi)
crates/cairo-lang-formatter/test_data/expected_results/linebreaking.cairo
line 172 at r1 (raw file):
sixth_arg: T, seventh_arg: T, | {
Now I'm not sure about the change, let's discuss.
Code quote:
let foo = |
first_arg: T,
second_arg: T,
third_arg: T,
fourth_arg: T,
fifth_arg: T,
sixth_arg: T,
seventh_arg: T,
| {
14940a6
to
6d4dcc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @orizi)
crates/cairo-lang-formatter/test_data/expected_results/linebreaking.cairo
line 172 at r1 (raw file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
Now I'm not sure about the change, let's discuss.
I prefer it this way. It's more consistent- aligned with the recent closure fix we just implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
crates/cairo-lang-formatter/test_data/expected_results/linebreaking.cairo
line 172 at r1 (raw file):
Previously, dean-starkware wrote…
I prefer it this way. It's more consistent- aligned with the recent closure fix we just implemented.
looks much better to my eyes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dean-starkware)
No description provided.