Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update indirect_impl_alias.cairo #7176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GuroChil
Copy link

Pull Request: Refactor Implementation Aliases for Clarity

Summary of Changes

This pull request updates implementation alias names in tests/bug_samples/indirect_impl_alias.cairo to enhance clarity and maintainability.

Changes Made

  1. Renamed Implementation Aliases:

    • Old Name: ImplAlias1
    • New Name: ImplFelt2521
    • Reason: Clarifies that this implementation is for the felt252 type.
  2. Renamed Implementation Aliases:

    • Old Name: ImplAlias2
    • New Name: ImplFelt2522
    • Reason: Indicates this implementation is also related to the felt252 type.

These changes improve code clarity, making it easier for developers to understand the purpose of each implementation.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @GuroChil)


a discussion (no related file):
please close PR.
this makes nothing clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants