Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added caching to trait functions and generated impl's functions #7265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TomerStarkware
Copy link
Collaborator

No description provided.

@TomerStarkware TomerStarkware requested a review from orizi February 12, 2025 15:31
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


crates/cairo-lang-lowering/src/cache/mod.rs line 2154 at r1 (raw file):

            }
            ImplLongId::ImplVar(_impl_var_id) => todo!(),
            ImplLongId::ImplImpl(_impl_impl_id) => todo!(),

remove all todos

Code quote:

            ImplLongId::ImplVar(_impl_var_id) => todo!(),
            ImplLongId::ImplImpl(_impl_impl_id) => todo!(),

@TomerStarkware TomerStarkware force-pushed the tomer/precompilation branch 3 times, most recently from aa8fc69 to 374acc5 Compare February 17, 2025 08:51
@TomerStarkware TomerStarkware force-pushed the tomer/cache_trait_funciton_and_generated_impls branch from f9d5989 to 01a219b Compare February 17, 2025 08:58
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

@TomerStarkware TomerStarkware force-pushed the tomer/cache_trait_funciton_and_generated_impls branch from 01a219b to 023cf73 Compare February 17, 2025 10:49
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

@TomerStarkware TomerStarkware force-pushed the tomer/cache_trait_funciton_and_generated_impls branch 2 times, most recently from 99b9179 to 321f9c4 Compare February 17, 2025 12:51
@TomerStarkware TomerStarkware changed the base branch from tomer/precompilation to main February 17, 2025 12:51
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

@TomerStarkware TomerStarkware force-pushed the tomer/cache_trait_funciton_and_generated_impls branch from 321f9c4 to 03dd11d Compare February 17, 2025 14:27
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants