refactor: no need to recalculate the actual updates #2291
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: CI | |
| on: | |
| push: | |
| branches: | |
| - main | |
| - main-v[0-9]+.** | |
| tags: | |
| - v[0-9]+.** | |
| pull_request: | |
| types: | |
| - opened | |
| - reopened | |
| - synchronize | |
| - auto_merge_enabled | |
| - edited | |
| merge_group: | |
| types: [checks_requested] | |
| jobs: | |
| commitlint: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| with: | |
| fetch-depth: 0 | |
| - name: Install commitlint | |
| run: npm install --global @commitlint/cli @commitlint/config-conventional | |
| - name: Validate PR commits with commitlint | |
| if: github.event_name == 'pull_request' && !(contains(github.event.pull_request.title, '/merge-main') || contains(github.event.pull_request.title, '/merge main')) | |
| env: | |
| BASE_SHA: ${{ github.event.pull_request.base.sha }} | |
| HEAD_SHA: ${{ github.event.pull_request.head.sha }} | |
| run: commitlint --from "$BASE_SHA" --to "$HEAD_SHA" --verbose | |
| - name: Validate PR title with commitlint | |
| if: github.event_name != 'merge_group' && github.event_name != 'push' && !(contains(github.event.pull_request.title, '/merge-main') || contains(github.event.pull_request.title, '/merge main')) | |
| env: | |
| TITLE: ${{ github.event.pull_request.title }} | |
| run: echo "$TITLE" | commitlint --verbose | |
| format: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: dtolnay/rust-toolchain@master | |
| with: | |
| components: rustfmt | |
| toolchain: nightly-2024-01-12 | |
| - uses: Swatinem/rust-cache@v2 | |
| - run: scripts/rust_fmt.sh --check | |
| clippy: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: dtolnay/rust-toolchain@stable | |
| with: | |
| components: clippy | |
| - uses: Swatinem/rust-cache@v2 | |
| - run: scripts/clippy.sh | |
| taplo: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: dtolnay/rust-toolchain@stable | |
| - uses: Swatinem/rust-cache@v2 | |
| - uses: baptiste0928/cargo-install@v3 | |
| with: | |
| crate: taplo-cli | |
| version: '0.9.0' | |
| locked: true | |
| - run: scripts/taplo.sh | |
| run-python-tests: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: actions/setup-python@v2 | |
| with: | |
| python-version: '3.9' | |
| - run: | | |
| python -m pip install --upgrade pip | |
| pip install pytest | |
| - run: pytest scripts/merge_paths_test.py | |
| run-tests: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: dtolnay/rust-toolchain@stable | |
| - uses: Swatinem/rust-cache@v2 | |
| - run: cargo test | |
| run-regression-tests: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: dtolnay/rust-toolchain@stable | |
| - uses: Swatinem/rust-cache@v2 | |
| - id: auth | |
| uses: "google-github-actions/auth@v2" | |
| with: | |
| credentials_json: ${{ secrets.COMMITER_PRODUCTS_EXT_WRITER_JSON }} | |
| - uses: 'google-github-actions/setup-gcloud@v2' | |
| - run: echo "BENCH_INPUT_FILES_PREFIX=$(cat ./crates/committer_cli/src/tests/flow_test_files_prefix)" >> $GITHUB_ENV | |
| - run: gcloud storage cp gs://committer-testing-artifacts/$BENCH_INPUT_FILES_PREFIX/tree_flow_inputs.json ./crates/committer_cli/benches/tree_flow_inputs.json | |
| - run: gcloud storage cp gs://committer-testing-artifacts/$BENCH_INPUT_FILES_PREFIX/committer_flow_inputs.json ./crates/committer_cli/benches/committer_flow_inputs.json | |
| - run: cargo test --release -- --include-ignored test_regression | |
| benchmarking: | |
| runs-on: ubuntu-latest | |
| steps: | |
| # Checkout the base branch to get the old code. | |
| - uses: actions/checkout@v4 | |
| with: | |
| ref: ${{ github.base_ref }} | |
| - uses: Swatinem/rust-cache@v2 | |
| # Download the old benchmark inputs. | |
| - id: auth | |
| uses: "google-github-actions/auth@v2" | |
| with: | |
| credentials_json: ${{ secrets.COMMITER_PRODUCTS_EXT_WRITER_JSON }} | |
| - uses: 'google-github-actions/setup-gcloud@v2' | |
| - run: echo "OLD_BENCH_INPUT_FILES_PREFIX=$(cat ./crates/committer_cli/src/tests/flow_test_files_prefix)" >> $GITHUB_ENV | |
| - run: gcloud storage cp gs://committer-testing-artifacts/$OLD_BENCH_INPUT_FILES_PREFIX/tree_flow_inputs.json ./crates/committer_cli/benches/tree_flow_inputs.json | |
| - run: gcloud storage cp gs://committer-testing-artifacts/$OLD_BENCH_INPUT_FILES_PREFIX/committer_flow_inputs.json ./crates/committer_cli/benches/committer_flow_inputs.json | |
| # List the existing benchmarks. | |
| - run: | | |
| cargo bench -- --list | grep ': benchmark$' | sed -e "s/: benchmark$//" > benchmarks_list.txt | |
| # Benchmark the old code. | |
| - run: cargo bench | |
| # Backup the downloaded files to avoid re-downloading them if they didn't change (overwritten by checkout). | |
| - run: mv ./crates/committer_cli/benches/tree_flow_inputs.json ./crates/committer_cli/benches/tree_flow_inputs.json_bu | |
| - run: mv ./crates/committer_cli/benches/committer_flow_inputs.json ./crates/committer_cli/benches/committer_flow_inputs.json_bu | |
| # Checkout the new code. | |
| - uses: actions/checkout@v4 | |
| with: | |
| clean: false | |
| - run: echo "NEW_BENCH_INPUT_FILES_PREFIX=$(cat ./crates/committer_cli/src/tests/flow_test_files_prefix)" >> $GITHUB_ENV | |
| # Input files didn't change. | |
| - if: env.OLD_BENCH_INPUT_FILES_PREFIX == env.NEW_BENCH_INPUT_FILES_PREFIX | |
| run: | | |
| mv ./crates/committer_cli/benches/tree_flow_inputs.json_bu ./crates/committer_cli/benches/tree_flow_inputs.json | |
| mv ./crates/committer_cli/benches/committer_flow_inputs.json_bu ./crates/committer_cli/benches/committer_flow_inputs.json | |
| # Input files did change, download new inputs. | |
| - if: env.OLD_BENCH_INPUT_FILES_PREFIX != env.NEW_BENCH_INPUT_FILES_PREFIX | |
| run: | | |
| gcloud storage cp gs://committer-testing-artifacts/$NEW_BENCH_INPUT_FILES_PREFIX/tree_flow_inputs.json ./crates/committer_cli/benches/tree_flow_inputs.json | |
| gcloud storage cp gs://committer-testing-artifacts/$NEW_BENCH_INPUT_FILES_PREFIX/committer_flow_inputs.json ./crates/committer_cli/benches/committer_flow_inputs.json | |
| # Benchmark the new code, splitting the benchmarks, and prepare the results for posting a comment. | |
| - run: bash ./crates/committer_cli/benches/bench_split_and_prepare_post.sh benchmarks_list.txt bench_new.txt | |
| - run: echo BENCHES_RESULT=$(cat bench_new.txt) >> $GITHUB_ENV | |
| # Post comment in case of performance regression or improvement. | |
| - run: npm install fs | |
| - if: contains(env.BENCHES_RESULT, 'regressed') || contains(env.BENCHES_RESULT, 'improved') | |
| uses: actions/github-script@v6 | |
| with: | |
| script: | | |
| const fs = require('fs') | |
| github.rest.issues.createComment({ | |
| issue_number: context.issue.number, | |
| owner: context.repo.owner, | |
| repo: context.repo.repo, | |
| body: fs.readFileSync('bench_new.txt', 'utf8'), | |
| path: 'Commits' | |
| }) | |
| gcs-push: | |
| runs-on: ubuntu-20.04 | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: dtolnay/rust-toolchain@stable | |
| - uses: Swatinem/rust-cache@v2 | |
| # Commit hash on pull request event would be the head commit of the branch. | |
| - name: Get commit hash prefix for PR update | |
| if: ${{ github.event_name == 'pull_request' }} | |
| env: | |
| COMMIT_SHA: ${{ github.event.pull_request.head.sha }} | |
| run: echo "SHORT_HASH=${COMMIT_SHA:0:7}" >> $GITHUB_ENV | |
| # On push event (to main, for example) we should take the commit post-push. | |
| - name: Get commit hash prefix for merge | |
| if: ${{ github.event_name != 'pull_request' }} | |
| env: | |
| COMMIT_SHA: ${{ github.event.after }} | |
| run: echo "SHORT_HASH=${COMMIT_SHA:0:7}" >> $GITHUB_ENV | |
| - name: Build CLI binary | |
| run: cargo build -p committer_cli -r --bin committer_cli --target-dir CLI_TARGET | |
| - id: auth | |
| uses: "google-github-actions/auth@v2" | |
| with: | |
| credentials_json: ${{ secrets.COMMITER_PRODUCTS_EXT_WRITER_JSON }} | |
| - name: Upload binary to GCP | |
| id: upload_file | |
| uses: "google-github-actions/upload-cloud-storage@v2" | |
| with: | |
| path: "CLI_TARGET/release/committer_cli" | |
| destination: "committer-products-external/${{ env.SHORT_HASH }}/release/" | |
| udeps: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: dtolnay/rust-toolchain@master | |
| name: "Rust Toolchain Setup" | |
| with: | |
| toolchain: nightly-2024-01-12 | |
| - uses: Swatinem/rust-cache@v2 | |
| id: "cache-cargo" | |
| - if: ${{ steps.cache-cargo.outputs.cache-hit != 'true' }} | |
| name: "Download and run cargo-udeps" | |
| run: | | |
| wget -O - -c https://github.com/est31/cargo-udeps/releases/download/v0.1.45/cargo-udeps-v0.1.45-x86_64-unknown-linux-gnu.tar.gz | tar -xz | |
| cargo-udeps-*/cargo-udeps udeps | |
| env: | |
| RUSTUP_TOOLCHAIN: nightly-2024-01-12 | |
| all-tests: | |
| runs-on: ubuntu-latest | |
| needs: | |
| - clippy | |
| - commitlint | |
| - format | |
| - run-python-tests | |
| - run-tests | |
| - taplo | |
| - udeps | |
| steps: | |
| - name: Decide whether all the needed jobs succeeded or failed | |
| uses: re-actors/[email protected] | |
| with: | |
| jobs: ${{ toJSON(needs) }} |