fix: supporting commit for non modified trees

[nimrod-starkware]

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 84.09091% with 7 lines in your changes missing coverage. Please review.

Project coverage is 63.67%. Comparing base (d26e0e5) to head (019e82b).

Files	Patch %	Lines
...patricia_merkle_tree/updated_skeleton_tree/tree.rs	50.00%	3 Missing ⚠️
...itter/src/patricia_merkle_tree/filled_tree/tree.rs	85.71%	1 Missing and 1 partial ⚠️
...ted_skeleton_tree/compute_updated_skeleton_tree.rs	87.50%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   63.07%   63.67%   +0.59%     
==========================================
  Files          36       36              
  Lines        1617     1660      +43     
  Branches     1617     1660      +43     
==========================================
+ Hits         1020     1057      +37     
- Misses        548      552       +4     
- Partials       49       51       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @nimrod-starkware and @TzahiTaub)

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/compute_updated_skeleton_tree.rs line 405 at r1 (raw file):

    }

    pub(crate) fn create_unmodified(

this has to be pub(crate)? if it's private you can't call it from create?

Code quote:

pub(crate) 

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/compute_updated_skeleton_tree.rs line 413 at r1 (raw file):

            .ok_or(UpdatedSkeletonTreeError::MissingNode(NodeIndex::ROOT))?;
        let OriginalSkeletonNode::UnmodifiedSubTree(root_hash) = original_root_node else {
            panic!("A root of tree without modifications is expected to be a sibling.")

Suggestion:

be an unmodified node

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/compute_updated_skeleton_tree_test.rs line 502 at r1 (raw file):

#[rstest]
#[case::empty_tree(0)]

is there an EMPTY_HASH or EMPTY_ROOT constant you can use?

Code quote:

0

[nimrod-starkware]

Reviewable status: 4 of 6 files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware and @TzahiTaub)

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/compute_updated_skeleton_tree.rs line 405 at r1 (raw file):

Previously, dorimedini-starkware wrote…

this has to be pub(crate)? if it's private you can't call it from create?

yes it can't be private, i think because i call it under impl UpdatedSkeletonTree for UpdatedSkeletonTreeImpl and not under impl UpdatedSkeletonTree

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/compute_updated_skeleton_tree.rs line 413 at r1 (raw file):

            .ok_or(UpdatedSkeletonTreeError::MissingNode(NodeIndex::ROOT))?;
        let OriginalSkeletonNode::UnmodifiedSubTree(root_hash) = original_root_node else {
            panic!("A root of tree without modifications is expected to be a sibling.")

Done.

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/compute_updated_skeleton_tree_test.rs line 502 at r1 (raw file):

Previously, dorimedini-starkware wrote…

is there an EMPTY_HASH or EMPTY_ROOT constant you can use?

Done.

[dorimedini-starkware]

Reviewed 1 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)