-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change the hierarchy between test and testing #211
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 63.74% 63.51% -0.23%
==========================================
Files 36 36
Lines 1663 1669 +6
Branches 1663 1669 +6
==========================================
Hits 1060 1060
- Misses 552 558 +6
Partials 51 51 ☔ View full report in Codecov by Sentry. |
4a6abaa
to
e4411d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/committer/Cargo.toml
line 27 at r1 (raw file):
hex.workspace = true rand.workspace = true rstest.workspace = true
its removed since its only dev-dependencies but we couldn't remove it until today since testing and test was mixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)
crates/committer/src/patricia_merkle_tree.rs
line 12 at r1 (raw file):
#[cfg(feature = "testing")] pub mod testing_utils;
Suggestion:
#[cfg(test)]
pub mod internal_test_utils;
#[cfg(feature = "testing")]
pub mod external_test_utils;
e4411d0
to
99a8c5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
99a8c5f
to
8727a04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
Separate between test and testing. Now, the test depends on testing, meaning that cfg(test) also compiles the testing file,
but testing does not include a test file.
This change is