Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change the hierarchy between test and testing #211

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

AvivYossef-starkware
Copy link
Collaborator

@AvivYossef-starkware AvivYossef-starkware commented Jun 9, 2024

Separate between test and testing. Now, the test depends on testing, meaning that cfg(test) also compiles the testing file,
but testing does not include a test file.


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.51%. Comparing base (5f0105f) to head (8727a04).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   63.74%   63.51%   -0.23%     
==========================================
  Files          36       36              
  Lines        1663     1669       +6     
  Branches     1663     1669       +6     
==========================================
  Hits         1060     1060              
- Misses        552      558       +6     
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/committer/Cargo.toml line 27 at r1 (raw file):

hex.workspace = true
rand.workspace = true
rstest.workspace = true

its removed since its only dev-dependencies but we couldn't remove it until today since testing and test was mixed

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)


crates/committer/src/patricia_merkle_tree.rs line 12 at r1 (raw file):

#[cfg(feature = "testing")]
pub mod testing_utils;

Suggestion:

#[cfg(test)]
pub mod internal_test_utils;

#[cfg(feature = "testing")]
pub mod external_test_utils;

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Jun 9, 2024
Merged via the queue into main with commit 8bba826 Jun 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants