test(block_hash): tx data test #216
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 63.74% 63.77% +0.03%
==========================================
Files 36 35 -1
Lines 1663 1662 -1
Branches 1663 1662 -1
==========================================
Hits 1060 1060
+ Misses 552 551 -1
Partials 51 51 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1, all commit messages.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @yoavGrs)
a discussion (no related file):
why was block info removed in this pr?
Previously, dorimedini-starkware wrote…
I'm removing it in the python as well. |
There was a problem hiding this comment.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @yoavGrs)
a discussion (no related file):
Previously, yoavGrs wrote…
I'm removing it in the python as well.
The relevant fields are already in the transaction output.
please split this PR
block info deletion is unrelated to the test addition
yoavGrs
force-pushed
the
yoav/block_hash/tx_data_object
branch
from
7907cd2
to
c5c79d4
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
please split this PR
block info deletion is unrelated to the test addition
Done.
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)
Replace block info test with tx data test.
This change is