Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove as_fully_indexed second definition #220

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

TzahiTaub
Copy link
Contributor

@TzahiTaub TzahiTaub commented Jun 13, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.80%. Comparing base (70b8e73) to head (515bab9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   64.80%   64.80%           
=======================================
  Files          36       36           
  Lines        1682     1682           
  Branches     1682     1682           
=======================================
  Hits         1090     1090           
  Misses        541      541           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TzahiTaub TzahiTaub force-pushed the tzahi/skeleton/UpdatedSkeletonTree_create_unit_tests branch from a03b1f4 to 2920a73 Compare June 13, 2024 13:20
@TzahiTaub TzahiTaub force-pushed the tzahi/tests/refactor/remove_as_fully_indexed_copy branch from 97f301d to 4faa79e Compare June 13, 2024 13:20
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

Base automatically changed from tzahi/skeleton/UpdatedSkeletonTree_create_unit_tests to main June 13, 2024 14:00
@TzahiTaub TzahiTaub force-pushed the tzahi/tests/refactor/remove_as_fully_indexed_copy branch from 4faa79e to 515bab9 Compare June 13, 2024 14:01
@TzahiTaub TzahiTaub enabled auto-merge June 13, 2024 14:02
@TzahiTaub TzahiTaub added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit cee3703 Jun 13, 2024
21 checks passed
@TzahiTaub TzahiTaub deleted the tzahi/tests/refactor/remove_as_fully_indexed_copy branch June 13, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants