Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(skeleton): rename updated skeleton compute file to create_tree_helper #221

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

TzahiTaub
Copy link
Contributor

@TzahiTaub TzahiTaub commented Jun 13, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.80%. Comparing base (774f1ea) to head (c4aa70b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   64.80%   64.80%           
=======================================
  Files          36       36           
  Lines        1682     1682           
  Branches     1682     1682           
=======================================
  Hits         1090     1090           
  Misses        541      541           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TzahiTaub TzahiTaub force-pushed the tzahi/tests/refactor/remove_as_fully_indexed_copy branch from 4faa79e to 515bab9 Compare June 13, 2024 14:01
@TzahiTaub TzahiTaub force-pushed the tzahi/refactor/rename_updated_compute_module branch from 5673394 to 520b48c Compare June 13, 2024 14:02
Base automatically changed from tzahi/tests/refactor/remove_as_fully_indexed_copy to main June 13, 2024 14:04
@TzahiTaub TzahiTaub force-pushed the tzahi/refactor/rename_updated_compute_module branch from 520b48c to 9c3d086 Compare June 13, 2024 14:05
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@TzahiTaub TzahiTaub force-pushed the tzahi/refactor/rename_updated_compute_module branch from 9c3d086 to c4aa70b Compare June 16, 2024 09:28
Copy link
Contributor Author

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@TzahiTaub TzahiTaub added this pull request to the merge queue Jun 16, 2024
Merged via the queue into main with commit d995ca5 Jun 16, 2024
12 checks passed
@TzahiTaub TzahiTaub deleted the tzahi/refactor/rename_updated_compute_module branch June 16, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants