Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed forest traits #285

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Jul 9, 2024

This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 29.54545% with 31 lines in your changes missing coverage. Please review.

Project coverage is 70.65%. Comparing base (616d9af) to head (aebf66c).

Files Patch % Lines
crates/committer/src/block_committer/commit.rs 0.00% 17 Missing ⚠️
...ter/src/patricia_merkle_tree/filled_tree/forest.rs 0.00% 8 Missing ⚠️
...rkle_tree/updated_skeleton_tree/skeleton_forest.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   70.55%   70.65%   +0.10%     
==========================================
  Files          38       38              
  Lines        2034     2021      -13     
  Branches     2034     2021      -13     
==========================================
- Hits         1435     1428       -7     
+ Misses        530      524       -6     
  Partials       69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@nimrod-starkware nimrod-starkware added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 2fbab24 Jul 9, 2024
25 checks passed
@nimrod-starkware nimrod-starkware deleted the nimrod/forests_non_generic branch July 9, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants