Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename benchmark_tests to regression_tests #295

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

aner-starkware
Copy link
Contributor

@aner-starkware aner-starkware commented Jul 9, 2024

This change is Reviewable

@aner-starkware aner-starkware self-assigned this Jul 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.65%. Comparing base (1a814b9) to head (e8f6c6a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   70.65%   70.65%           
=======================================
  Files          38       38           
  Lines        2021     2021           
  Branches     2021     2021           
=======================================
  Hits         1428     1428           
  Misses        524      524           
  Partials       69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 9, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.700 ms 33.734 ms 33.769 ms]
change: [-3.8625% -2.4315% -1.1502%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
6 (6.00%) high mild
1 (1.00%) high severe

Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@aner-starkware aner-starkware added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit adf31b2 Jul 10, 2024
14 checks passed
@aner-starkware aner-starkware deleted the aner/rename_regression_tests branch July 10, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants