Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: no need to recalculate the actual updates #307

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Jul 14, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.65%. Comparing base (e7a2b4f) to head (995a8b7).

Files Patch % Lines
crates/committer/src/block_committer/commit.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   70.74%   70.65%   -0.09%     
==========================================
  Files          38       38              
  Lines        2078     2082       +4     
  Branches     2078     2082       +4     
==========================================
+ Hits         1470     1471       +1     
- Misses        538      541       +3     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [28.991 ms 29.025 ms 29.062 ms]
change: [+1.1219% +1.3092% +1.4828%] (p = 0.00 < 0.05)
Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
7 (7.00%) high mild

Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [28.980 ms 29.081 ms 29.216 ms]
change: [+1.0717% +1.4289% +1.9206%] (p = 0.00 < 0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) high mild
4 (4.00%) high severe

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@nimrod-starkware nimrod-starkware added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 94d0be9 Jul 15, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants