Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use mock test utils in filled tree test #319

Conversation

AvivYossef-starkware
Copy link
Collaborator

@AvivYossef-starkware AvivYossef-starkware commented Jul 17, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.03%. Comparing base (f8fbe2f) to head (c63563f).

Additional details and impacted files
@@                                 Coverage Diff                                  @@
##           07-17-refactor_use_mock_leaf_in_create_tree_test     #319      +/-   ##
====================================================================================
- Coverage                                             70.31%   70.03%   -0.29%     
====================================================================================
  Files                                                    38       38              
  Lines                                                  2109     2109              
  Branches                                               2109     2109              
====================================================================================
- Hits                                                   1483     1477       -6     
- Misses                                                  556      562       +6     
  Partials                                                 70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.563 ms 33.700 ms 33.893 ms]
change: [-3.1316% -2.0970% -1.1704%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
3 (3.00%) high mild
5 (5.00%) high severe

@AvivYossef-starkware AvivYossef-starkware force-pushed the 07-17-refactor_use_mock_leaf_in_create_tree_test branch from 102c92d to 1b3c352 Compare July 17, 2024 14:47
@AvivYossef-starkware AvivYossef-starkware force-pushed the 07-17-refactor_use_mock_test_utils_in_filled_tree_test branch from 7f3b84f to efead81 Compare July 17, 2024 14:47
@AvivYossef-starkware AvivYossef-starkware force-pushed the 07-17-refactor_use_mock_leaf_in_create_tree_test branch from 1b3c352 to f8fbe2f Compare July 22, 2024 07:06
@AvivYossef-starkware AvivYossef-starkware force-pushed the 07-17-refactor_use_mock_test_utils_in_filled_tree_test branch 2 times, most recently from 031e6ae to 2835fec Compare July 22, 2024 07:12
Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [28.872 ms 28.929 ms 28.989 ms]
change: [+1.1926% +1.4466% +1.7231%] (p = 0.00 < 0.05)
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

@AvivYossef-starkware AvivYossef-starkware force-pushed the 07-17-refactor_use_mock_test_utils_in_filled_tree_test branch from 2835fec to dd68329 Compare July 22, 2024 08:11
@AvivYossef-starkware AvivYossef-starkware force-pushed the 07-17-refactor_use_mock_test_utils_in_filled_tree_test branch from dd68329 to c63563f Compare July 22, 2024 08:18
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware changed the base branch from 07-17-refactor_use_mock_leaf_in_create_tree_test to main July 22, 2024 10:23
@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit 2e85680 Jul 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants