Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: updated_skeleton_tree_impl #32

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

aner-starkware
Copy link
Contributor

@aner-starkware aner-starkware commented Apr 10, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 23.94%. Comparing base (8ec4d7a) to head (2dcea94).

Files Patch % Lines
.../src/patricia_merkle_tree/updated_skeleton_tree.rs 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   28.33%   23.94%   -4.39%     
==========================================
  Files           6        7       +1     
  Lines          60       71      +11     
  Branches       60       71      +11     
==========================================
  Hits           17       17              
- Misses         43       54      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @TzahiTaub)

@aner-starkware aner-starkware force-pushed the aner/updated_skeleton_impl branch 2 times, most recently from d725ef6 to 58ae545 Compare April 10, 2024 13:01
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @TzahiTaub)

@aner-starkware aner-starkware added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit bb357ca Apr 10, 2024
9 of 10 checks passed
@aner-starkware aner-starkware deleted the aner/updated_skeleton_impl branch April 10, 2024 13:37
@TzahiTaub
Copy link
Contributor

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree.rs line 22 at r3 (raw file):

struct UpdatedSkeletonTreeImpl<L: LeafDataTrait, H: HashFunction, TH: TreeHashFunction<L, H>> {
    skeleton_tree: HashMap<NodeIndex, UpdatedSkeletonNode<L>>,
    hash_function: H,

Non-blocking as it's out of this scope, but I don't think we need the hash functions in the updated (and Current) trees. These seem independent of the hash function. We should give them as args when calling compute_filled_tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants