-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: updated_skeleton_tree_impl #32
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 28.33% 23.94% -4.39%
==========================================
Files 6 7 +1
Lines 60 71 +11
Branches 60 71 +11
==========================================
Hits 17 17
- Misses 43 54 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @TzahiTaub)
d725ef6
to
58ae545
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @TzahiTaub)
58ae545
to
2dcea94
Compare
Non-blocking as it's out of this scope, but I don't think we need the hash functions in the updated (and Current) trees. These seem independent of the hash function. We should give them as args when calling compute_filled_tree. |
This change is