-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove hash generic args from the different tree traits #36
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=======================================
Coverage 18.88% 18.88%
=======================================
Files 7 7
Lines 90 90
Branches 90 90
=======================================
Hits 17 17
Misses 73 73 ☔ View full report in Codecov by Sentry. |
2fc4902
to
d8a4f44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @TzahiTaub)
crates/committer/src/patricia_merkle_tree/updated_skeleton_tree.rs
line 18 at r1 (raw file):
&self, tree_hash_func: &impl TreeHashFunction<L, H>, ) -> Result<impl FilledTree<L>, UpdatedSkeletonTreeError>;
say we define a struct PedersenTreeHash
and impl<L: LeafDataTrait> TreeHashFunction<L, PedersenHash> for PedersenTreeHash
; why would we need to pass an instance of PedersenTreeHash
? what is tree_hash_func
for?
Suggestion:
fn compute_filled_tree<H: HashFunction, TH: TreeHashFunction<L, H>>(
&self
) -> Result<impl FilledTree<L>, UpdatedSkeletonTreeError>;
d8a4f44
to
f8fdece
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @dorimedini-starkware)
crates/committer/src/patricia_merkle_tree/updated_skeleton_tree.rs
line 18 at r1 (raw file):
Previously, dorimedini-starkware wrote…
say we define a struct
PedersenTreeHash
andimpl<L: LeafDataTrait> TreeHashFunction<L, PedersenHash> for PedersenTreeHash
; why would we need to pass an instance ofPedersenTreeHash
? what istree_hash_func
for?
No need, got confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)
This change is