fix: changes to api

[amosStarkware]

This change is 

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.75%. Comparing base (d145432) to head (039416d).

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   29.75%   29.75%           
=======================================
  Files           8        8           
  Lines         121      121           
  Branches      121      121           
=======================================
  Hits           36       36           
  Misses         84       84           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[amosStarkware]

+reviewer:@dorimedini-starkware
@nimrod-starkware any more changes you need?

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/committer/src/patricia_merkle_tree/original_skeleton_tree.rs line 22 at r2 (raw file):

        root_hash: HashOutput,
        tree_height: TreeHeight,
    ) -> OriginalSkeletonTreeResult<impl OriginalSkeletonTree<L>>;

Rust requires a box when returning Self, but this way it doesn't

Code quote:

) -> OriginalSkeletonTreeResult<impl OriginalSkeletonTree<L>>;

[dorimedini-starkware]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware)

---

crates/committer/src/patricia_merkle_tree/original_skeleton_tree.rs line 18 at r2 (raw file):

pub(crate) trait OriginalSkeletonTree<L: LeafDataTrait> {
    fn compute_original_skeleton_tree(
        storage: &mut impl Storage,

must this be mutable...?

Code quote:

storage: &mut impl Storage

---

crates/committer/src/patricia_merkle_tree/original_skeleton_tree.rs line 22 at r2 (raw file):

Previously, amosStarkware wrote…

Rust requires a box when returning Self, but this way it doesn't

nice!

[amosStarkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/committer/src/patricia_merkle_tree/original_skeleton_tree.rs line 18 at r2 (raw file):

Previously, dorimedini-starkware wrote…

must this be mutable...?

It doesn't, thanks

[dorimedini-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)