Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add node_data/leaf_serde #63

Merged
merged 1 commit into from
Apr 24, 2024
Merged

chore: add node_data/leaf_serde #63

merged 1 commit into from
Apr 24, 2024

Conversation

amosStarkware
Copy link
Contributor

@amosStarkware amosStarkware commented Apr 23, 2024

This change is Reviewable

@amosStarkware amosStarkware self-assigned this Apr 23, 2024
@amosStarkware amosStarkware changed the base branch from main to amos/create_leaf April 23, 2024 16:57
Copy link
Contributor Author

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+reviewer:@dorimedini-starkware

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 72.34%. Comparing base (6e12429) to head (57bf31c).

Files Patch % Lines
...r/src/patricia_merkle_tree/node_data/leaf_serde.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   72.34%   72.34%           
=======================================
  Files          19       19           
  Lines         640      640           
  Branches      640      640           
=======================================
  Hits          463      463           
  Misses        147      147           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amosStarkware amosStarkware changed the base branch from amos/create_leaf to main April 24, 2024 08:23
@amosStarkware amosStarkware added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit d318e38 Apr 24, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants