refactor: splitting serializable trait #65
Conversation
AvivYossef-starkware
requested review from
dorimedini-starkware and
nimrod-starkware
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage 73.13% 73.13%
=======================================
Files 19 18 -1
Lines 644 644
Branches 644 644
=======================================
Hits 471 471
Misses 143 143
Partials 30 30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)
There was a problem hiding this comment.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
AvivYossef-starkware
force-pushed
the
aviv/impl_serializable_for_filled_node
branch
3 times, most recently
from
d780fa6
to
50ed640
Compare
AvivYossef-starkware
changed the base branch from
aviv/impl_serializable_for_filled_node
to
main
AvivYossef-starkware
force-pushed
the
aviv/refactor_splitting_serializable_trait
branch
from
e7df861
to
d6fb97b
Compare
There was a problem hiding this comment.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status:
AvivYossef-starkware
force-pushed
the
aviv/refactor_splitting_serializable_trait
branch
from
d6fb97b
to
67b337b
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_splitting_serializable_trait
branch
from
67b337b
to
9a57bbd
Compare
The proposal is to divide the serializable trait into two separate traits, namely serializable and deserializable. This will allow for a clearer separation of concerns between the serialization and deserialization processes.
This change is