Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add string data to CONTRACT_ERROR #141

Merged
merged 1 commit into from
Sep 21, 2023
Merged

add string data to CONTRACT_ERROR #141

merged 1 commit into from
Sep 21, 2023

Conversation

ArielElp
Copy link
Collaborator

@ArielElp ArielElp commented Sep 20, 2023

allows propagating errors from the blockifier or starknet_in_rust from the RPC


This change is Reviewable

Copy link
Collaborator

@amanusk amanusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One day, it would be great to have this structured. Otherwise lgtm

Copy link

@odednaor odednaor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArielElp)

@ArielElp ArielElp merged commit 4bb9c31 into master Sep 21, 2023
1 check passed
@ArielElp ArielElp deleted the improve_errors branch September 21, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants