-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validation script after adding structured errors #235
Conversation
This is great -- but I don't think we should change the specification in that way just to make validation possible. Looks like there's an open issue on Would it be possible to:
|
Agree that it is a bit backwards and not ideal. |
"CONTRACT_EXECUTION_ERROR": { | ||
"description": "structured error that can later be processed by wallets or sdks", | ||
"title": "contract execution error", | ||
"$ref": "#/components/schemas/CONTRACT_EXECUTION_ERROR_INNER" | ||
}, | ||
"CONTRACT_EXECUTION_ERROR_INNER": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is a much neater trick than the previous one! Thanks for finding out how to make this work! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thing you insisted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 3 of 3 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @kkovaacs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kkovaacs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissed @kkovaacs from a discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp and @kkovaacs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amanusk)
This does requires messages to be a list, which might not be what we want
This change is