Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation script after adding structured errors #235

Open
wants to merge 5 commits into
base: v0.8.0
Choose a base branch
from

Conversation

amanusk
Copy link
Collaborator

@amanusk amanusk commented Oct 20, 2024

This does requires messages to be a list, which might not be what we want

@kkovaacs
Copy link

This is great -- but I don't think we should change the specification in that way just to make validation possible.

Looks like there's an open issue on @json-schema-tools/dereferencer for handling recursive schemas: json-schema-tools/dereferencer#608

Would it be possible to:

  • rebase this branch to the current state of things (after merging the starknet_getStorageProof change)
  • include just the schema fixes that are purely fixes and maybe skip that single change that makes the child CONTRACT_EXECUTION_ERROR an array?

@amanusk
Copy link
Collaborator Author

amanusk commented Oct 22, 2024

Agree that it is a bit backwards and not ideal.
I'll try exploring ways to fix the validation script in a way that does not require this change.
But it would be a shame to forgo all validations going forward, and since this component is in the main API schema, it breaks validating all other schemas as well :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants