-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add size estimate for StarkProof #831
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @andrewmilson and the rest of your teammates on Graphite |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #831 +/- ##
==========================================
- Coverage 92.60% 91.92% -0.69%
==========================================
Files 89 89
Lines 12055 12154 +99
Branches 12055 12154 +99
==========================================
+ Hits 11164 11173 +9
- Misses 784 874 +90
Partials 107 107 ☔ View full report in Codecov by Sentry. |
c5d5eb0
to
dce64f1
Compare
dce64f1
to
b7bf1fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @andrewmilson)
a discussion (no related file):
Can you add an example of the size_estimate output?
crates/prover/src/core/prover/mod.rs
line 254 at r1 (raw file):
impl SizeEstimate for BaseField { fn size_estimate(&self) -> usize { mem::size_of::<Self>()
Can you add unit test that the base sizes are correct?
Code quote:
mem::size_of::<Self>()
b7bf1fe
to
ba4205c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)
a discussion (no related file):
Previously, shaharsamocha7 wrote…
Can you add an example of the size_estimate output?
Done.
crates/prover/src/core/prover/mod.rs
line 254 at r1 (raw file):
Previously, shaharsamocha7 wrote…
Can you add unit test that the base sizes are correct?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)
This change is