Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size estimate for StarkProof #831

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Sep 15, 2024

This change is Reviewable

Copy link
Contributor Author

andrewmilson commented Sep 15, 2024

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 16.21622% with 93 lines in your changes missing coverage. Please review.

Project coverage is 91.92%. Comparing base (215b1cd) to head (ba4205c).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
crates/prover/src/core/prover/mod.rs 16.21% 93 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #831      +/-   ##
==========================================
- Coverage   92.60%   91.92%   -0.69%     
==========================================
  Files          89       89              
  Lines       12055    12154      +99     
  Branches    12055    12154      +99     
==========================================
+ Hits        11164    11173       +9     
- Misses        784      874      +90     
  Partials      107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 09-11-Add_size_estimate_for_StarkProof branch from c5d5eb0 to dce64f1 Compare September 15, 2024 08:36
@andrewmilson andrewmilson marked this pull request as ready for review September 15, 2024 08:37
@andrewmilson andrewmilson force-pushed the 09-11-Add_size_estimate_for_StarkProof branch from dce64f1 to b7bf1fe Compare September 15, 2024 08:38
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @andrewmilson)

a discussion (no related file):
Can you add an example of the size_estimate output?



crates/prover/src/core/prover/mod.rs line 254 at r1 (raw file):

impl SizeEstimate for BaseField {
    fn size_estimate(&self) -> usize {
        mem::size_of::<Self>()

Can you add unit test that the base sizes are correct?

Code quote:

mem::size_of::<Self>()

@andrewmilson andrewmilson force-pushed the 09-11-Add_size_estimate_for_StarkProof branch from b7bf1fe to ba4205c Compare September 15, 2024 20:59
Copy link
Contributor Author

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

a discussion (no related file):

Previously, shaharsamocha7 wrote…

Can you add an example of the size_estimate output?

Done.



crates/prover/src/core/prover/mod.rs line 254 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Can you add unit test that the base sizes are correct?

Done.

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

@andrewmilson andrewmilson merged commit cdf66f3 into dev Sep 16, 2024
16 checks passed
@andrewmilson andrewmilson deleted the 09-11-Add_size_estimate_for_StarkProof branch September 16, 2024 19:18
jarnesino pushed a commit to jarnesino/stwo that referenced this pull request Sep 17, 2024
jarnesino pushed a commit to jarnesino/stwo that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants