Parallelize bit reverse m31.

[alonh5]

This change is 

[alonh5]

• Parallelize bit reverse m31. #855 👈
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (f1f1d18) to head (4018d1d).
Report is 7 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #855      +/-   ##
==========================================
- Coverage   92.21%   92.06%   -0.16%     
==========================================
  Files          90       90              
  Lines       12322    12659     +337     
  Branches    12322    12659     +337     
==========================================
+ Hits        11363    11654     +291     
- Misses        853      893      +40     
- Partials      106      112       +6     

Flag	Coverage Δ
	92.06% <100.00%> (-0.16%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andrewmilson]

Reviewed all commit messages.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Alon-Ti, @alonh5, and @shaharsamocha7)

---

crates/prover/src/core/backend/simd/m31.rs line 42 at r1 (raw file):

unsafe impl Send for UnsafePackedM31Array {}
unsafe impl Sync for UnsafePackedM31Array {}

Perhaps we can move to utils.rs and unify with the UnsafeMut types in the fft code

Suggestion:

pub struct UnsafeMut<T>(pub *mut T);
impl<T> UnsafeMut<T> {
    pub unsafe fn get(&self) -> *mut T {
        self.0
    }
}

unsafe impl<T> Send for UnsafeMut<T> {}
unsafe impl<T> Sync for UnsafeMut<T> {}

[alonh5]

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @Alon-Ti, @andrewmilson, and @shaharsamocha7)

---

crates/prover/src/core/backend/simd/m31.rs line 42 at r1 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…

Perhaps we can move to utils.rs and unify with the UnsafeMut types in the fft code

Great idea. Done.

[andrewmilson]

With comment

Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @Alon-Ti, @alonh5, and @shaharsamocha7)

---

crates/prover/src/core/mod.rs line 99 at r2 (raw file):

unsafe impl<T> Send for UnsafeConst<T> {}
unsafe impl<T> Sync for UnsafeConst<T> {}

Maybe simd/utils.rs is better.
Not sure we want to expose these in our public API

Code quote:

// TODO(andrew): Examine usage of unsafe in SIMD FFT.
pub struct UnsafeMut<T: ?Sized>(pub *mut T);
impl<T: ?Sized> UnsafeMut<T> {
    /// # Safety
    ///
    /// Returns a raw mutable pointer.
    pub unsafe fn get(&self) -> *mut T {
        self.0
    }
}

unsafe impl<T: ?Sized> Send for UnsafeMut<T> {}
unsafe impl<T: ?Sized> Sync for UnsafeMut<T> {}

pub struct UnsafeConst<T>(pub *const T);
impl<T> UnsafeConst<T> {
    /// # Safety
    ///
    /// Returns a raw constant pointer.
    pub unsafe fn get(&self) -> *const T {
        self.0
    }
}

unsafe impl<T> Send for UnsafeConst<T> {}
unsafe impl<T> Sync for UnsafeConst<T> {}

[shaharsamocha7]

I moved UnsafeMut to simd utils

Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions (waiting on @Alon-Ti, @alonh5, and @andrewmilson)

[andrewmilson]

Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions (waiting on @Alon-Ti and @alonh5)