Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print component information #859

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

shaharsamocha7
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 commented Oct 7, 2024

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shaharsamocha7 and the rest of your teammates on Graphite Graphite

Copy link
Collaborator Author

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

a discussion (no related file):
I can also add it to the blake example


@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 92.28%. Comparing base (bb0cce2) to head (e0ee9a8).

Files with missing lines Patch % Lines
...rates/prover/src/constraint_framework/component.rs 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #859      +/-   ##
==========================================
- Coverage   92.48%   92.28%   -0.20%     
==========================================
  Files          91       91              
  Lines       12407    12433      +26     
  Branches    12407    12433      +26     
==========================================
  Hits        11474    11474              
- Misses        825      851      +26     
  Partials      108      108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

a discussion (no related file):

Previously, shaharsamocha7 wrote…

I can also add it to the blake example

:lgtm:


@shaharsamocha7 shaharsamocha7 merged commit ca3d103 into dev Oct 10, 2024
15 of 16 checks passed
@shaharsamocha7 shaharsamocha7 deleted the 10-07-Print_component_information branch October 10, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants