Expression Evaluator.

[Alon-Ti]

No description provided.

[reviewable-StarkWare]

This change is 

[Alon-Ti]

• Expression Evaluator. #861 👈
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Alon-Ti and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 58.50340% with 61 lines in your changes missing coverage. Please review.

Project coverage is 91.89%. Comparing base (ce5b975) to head (888c6e4).

Files with missing lines	Patch %	Lines
crates/prover/src/constraint_framework/expr.rs	58.50%	59 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #861      +/-   ##
==========================================
- Coverage   92.29%   91.89%   -0.40%     
==========================================
  Files          91       92       +1     
  Lines       12439    12586     +147     
  Branches    12439    12586     +147     
==========================================
+ Hits        11480    11566      +86     
- Misses        851      910      +59     
- Partials      108      110       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andrewmilson]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @Alon-Ti)

---

crates/prover/src/constraint_framework/expr.rs line 25 at r1 (raw file):

    // if a = SecureCol(a0, a1, a2, a3), b = SecureCol(b0, b1, b2, b3) then
    // a + b evaluates to Add(a, b) rather than
    // SecureCol(Add(a0, b0), Add(a1, b1), Add(a2, b2), Add(a3, b3))

Docstring

Suggestion:

    Col(ColumnExpr),
    /// An atomic secure column constructed from 4 expressions.
    /// Expressions on the secure column are not reduced, i.e,
    /// if `a = SecureCol(a0, a1, a2, a3), b = SecureCol(b0, b1, b2, b3)` then
    /// `a + b` evaluates to `Add(a, b)` rather than
    /// `SecureCol(Add(a0, b0), Add(a1, b1), Add(a2, b2), Add(a3, b3))`

---

crates/prover/src/constraint_framework/expr.rs line 83 at r1 (raw file):

        *self = Expr::Mul(Box::new(self.clone()), Box::new(rhs));
    }
}

Optional suggestion

Suggestion:

impl AddAssign for Expr {
    fn add_assign(&mut self, rhs: Self) {
        *self = self.clone() + rhs;
    }
}

impl MulAssign for Expr {
    fn mul_assign(&mut self, rhs: Self) {
        *self = self.clone() * rhs;
    }
}

[Alon-Ti]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @andrewmilson)

---

crates/prover/src/constraint_framework/expr.rs line 25 at r1 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…

Docstring

Done.

---

crates/prover/src/constraint_framework/expr.rs line 83 at r1 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…

Optional suggestion

Done.

[Alon-Ti]

Merge activity

• Oct 20, 12:26 PM EDT: A user merged this pull request with Graphite.