use parallel batch inverse in logup #987
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Jan 13, 2025
Merged
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![semgrep-code-starkware-libs[bot]](https://avatars.githubusercontent.com/u/59333826?s=60&v=4){kind=small}
Comment on lines
262
to
228
| unsafe { | ||
| let value = self.numerator.packed_at(vec_row) | ||
| * *self.gen.denom_inv.data.get_unchecked(vec_row); | ||
| let value = self.numerator.packed_at(vec_row) * denom_inv[vec_row]; | ||
| let prev_value = self | ||
| .gen | ||
| .trace |
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ohad/parallel_batch_inverse #987 +/- ##
===============================================================
+ Coverage 92.24% 92.26% +0.01%
===============================================================
Files 105 105
Lines 14319 14316 -3
Branches 14319 14316 -3
===============================================================
Hits 13209 13209
+ Misses 1037 1034 -3
Partials 73 73 ☔ View full report in Codecov by Sentry. |
ohad-starkware
commented
Jan 13, 2025
Comment on lines
262
to
228
| unsafe { | ||
| let value = self.numerator.packed_at(vec_row) | ||
| * *self.gen.denom_inv.data.get_unchecked(vec_row); | ||
| let value = self.numerator.packed_at(vec_row) * denom_inv[vec_row]; | ||
| let prev_value = self | ||
| .gen | ||
| .trace |
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse
branch
from
3fcae0e to
fbfd130
Compare
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse_in_logup
branch
2 times, most recently
from
0f55d3d to
d68e513
Compare
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse
branch
2 times, most recently
from
13219eb to
6018cd7
Compare
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse_in_logup
branch
from
d68e513 to
30017a8
Compare
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse
branch
from
6018cd7 to
4502270
Compare
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse_in_logup
branch
from
30017a8 to
26eb5c6
Compare
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse
branch
from
4502270 to
682a4c4
Compare
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse_in_logup
branch
from
26eb5c6 to
081a7c5
Compare
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse
branch
from
682a4c4 to
799324a
Compare
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse_in_logup
branch
from
081a7c5 to
5ffd96b
Compare
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse
branch
from
799324a to
333e755
Compare
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse_in_logup
branch
from
5ffd96b to
4f76592
Compare
There was a problem hiding this comment.
need to rebase
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware and @semgrep-code-starkware-libs[bot])
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse_in_logup
branch
from
4f76592 to
e26b074
Compare
ohad-starkware
force-pushed
the
ohad/parallel_batch_inverse
branch
from
333e755 to
30b8eda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.