[hrpsys_ros_bridge] chage RTC name of RangeROSBridge and PointCloudROSBridge #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dename as RTC component's name
YoheiKakiuchi
force-pushed
the
fix_rtc_name2
branch
2 times, most recently
from
832d0e6
to
8ca178f
Compare
YoheiKakiuchi
force-pushed
the
fix_rtc_name2
branch
from
8ca178f
to
bbb0e1a
Compare
mmurooka
reviewed
Mar 22, 2019
k-okada
approved these changes
Mar 22, 2019
There was a problem hiding this comment.
i think component name can be changed by arguments
https://github.com/tork-a/rtmros_nextage/blob/indigo-devel/nextage_ros_bridge/launch/nextage_ros_bridge_simulation.launch#L27
|
These components work for converting point cloud/lidar message from OpenRTM to ROS. By this PR, RTC name is set as the same of ROS nodename. |
mmurooka
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently name of RangeROSBridge component is RangeROSBridge0.rtc.
By this PR, the name of component is the same name as ROS nodename.