-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hrpsys_ros_bridge] chage RTC name of RangeROSBridge and PointCloudROSBridge #1059
base: master
Are you sure you want to change the base?
Conversation
…dename as RTC component's name
832d0e6
to
8ca178f
Compare
8ca178f
to
bbb0e1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By this PR, the name of component is the same name as ROS nodename.
I haven't use this component, and I'm not familiar with it.
Could you explain why it is necessary, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think component name can be changed by arguments
https://github.com/tork-a/rtmros_nextage/blob/indigo-devel/nextage_ros_bridge/launch/nextage_ros_bridge_simulation.launch#L27
These components work for converting point cloud/lidar message from OpenRTM to ROS. By this PR, RTC name is set as the same of ROS nodename. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for explanation. In which robot or environment, does this rtc used? In choreonoid simulation?
Currently name of RangeROSBridge component is RangeROSBridge0.rtc.
By this PR, the name of component is the same name as ROS nodename.