Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtmbuild] fix include/link path for openhrp3 (by ishiguroJSK) #1106

Merged
merged 2 commits into from
Dec 23, 2021

Conversation

Naoki-Hiraoka
Copy link
Contributor

@Naoki-Hiraoka Naoki-Hiraoka commented May 19, 2021

#1064 (comment) のコメントに書いてある修正点です.
#1104 から抽出しました.

openhrp3をソースから入れた時にchoreonoidや実機rosbridgeが立ち上がらない問題を回避するための変更です.

rtmbuildパッケージのcmakeファイル内のpathの順序を, #1062 で述べられているバグの発生条件を回避するように変更します.

自分のkinetic環境だと,この変更がないとopenhrp3をソースから入れた時にchoreononidでシミュレーションができませんでした.

Copy link
Member

@Utaro-M Utaro-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openhrp3をsourceで入れたtablisのubuntu16制御PCでWait for localhost:15005/HrpsysSeqStateROSBridge0.rtc:rsangle が出続ける問題が解決することを自分のワークスペースで確認しました。
masterのjaxonredのchoreonoidが立ち上がることも確認し副作用がないことを確認しました。

@Naoki-Hiraoka
Copy link
Contributor Author

お手すきの時にmergeしていただけますと幸いです.

Copy link
Contributor

@kindsenior kindsenior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naoki-Hiraoka Naoki-Hiraoka mentioned this pull request Jun 21, 2021
@Naoki-Hiraoka
Copy link
Contributor Author

@k-okada これがないと、Ubuntu16の実機が起動しません. 問題が無ければmergeをお願いします。

@k-okada k-okada merged commit d99980f into start-jsk:master Dec 23, 2021
@Naoki-Hiraoka Naoki-Hiraoka deleted the PR-rtmbuild branch December 24, 2021 04:12
@Naoki-Hiraoka
Copy link
Contributor Author

ありがとうございます

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants