Fix (ci): Fix testing image to work correctly for srcds/csgo
#165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regression in startersclan#153, where validation stopped working for `srcds/csgo`
joeltimothyoh
force-pushed
the
fix/ci-fix-testing-image-to-work-correctly-for-srcds-csgo
branch
from
2a18d77 to
4be4a83
Compare
There was a problem hiding this comment.
Validation shouldn't have stopped working as srcds/csgo uses APPID=740. What's clashing between the two games is CLIENT_APPID=730 which has only been useful for the following workaround. @leojonathanoh
|
oh okay, yes. closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression in #153, where validation stopped working for
srcds/csgo