Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Update and fix strings translation for Italian language #11145

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

gioppy
Copy link
Contributor

@gioppy gioppy commented Nov 19, 2024

Update and fix all strings translated with Google Translate in Italian.

@gioppy gioppy changed the title Update and fix strings translation for Italian language [5.x] Update and fix strings translation for Italian language Nov 19, 2024
@jasonvarga jasonvarga merged commit de247fa into statamic:5.x Nov 19, 2024
17 of 18 checks passed
@vitalijalbu
Copy link

vitalijalbu commented Nov 19, 2024

@gioppy @jasonvarga wanted to say that "PRO" (next to the logo of the navbar) is also translated in italian with "Professionale", that in my opinion PRO should be equal for all languages..

@gioppy
Copy link
Contributor Author

gioppy commented Nov 19, 2024

Tecnically you have right, Pro will be translated as "Professionale", but in this case the logo on the navbar will be too long, so i prefer the simple and slim "Pro"!

@jasonvarga
Copy link
Member

This PR changes it to just Pro which I think is good. I didn't notice Professionale when I ran Google Translate on everything. 👌

@ghost
Copy link

ghost commented Nov 20, 2024

This PR changes it to just Pro which I think is good. I didn't notice Professionale when I ran Google Translate on everything. 👌

heah, basically i think PRO can stay as non-translated string... for all languages.. 👀

@jasonvarga
Copy link
Member

I initially thought so too, but we made it translatable for languages that don't use English characters, like Persian or Arabic. They would still use "Pro" (and even "Statamic") but it would be written phonetically using their alphabet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants